Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sps_table support is broken, complete failure when seq_parameter_set_id != 0 #12

Open
ydirson opened this issue Jun 27, 2016 · 2 comments
Labels

Comments

@ydirson
Copy link

ydirson commented Jun 27, 2016

The memcpy at the end of read_seq_parameter_set_rbsp() overwrites the struct it just filled with
a copy of what's in sps_table. Since h->sps == h->sps_table[0] it just filled that one, the memcpy in the id=0 case is (un?)luckily a no-op, while in all other cases the values just read are just all cleared to 0.

Swapping src/dst can't work properly as is either, since h->sps == h->sps_table[0]: when we notice that seq_parameter_set_id != 0 we have already overwritten h->sps_table[0].

if(0)-ing this memcpy as a workaround works much better...

@aizvorski aizvorski added the bug label Aug 1, 2016
@aizvorski
Copy link
Owner

@ydirson I see what you mean! I think the code in PR #17 fixes that, could you give it a try?

@aizvorski
Copy link
Owner

aizvorski commented May 26, 2017

@ydirson Latest code in master should behave ok now. Could you test it, or give an example file to test with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants