Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to the serialdevices class to facilitate debugging. #11

Open
anushadatar opened this issue Jan 11, 2021 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@anushadatar
Copy link
Contributor

Mitigate some of the difficulty associated with debug and test by printing statuses, etc. for each step in the connection process if and only if DEBUG has been enabled (maybe use a logging library or something, or even just printing is fine). Test scripts should default to this option.

@anushadatar anushadatar added the enhancement New feature or request label Jan 11, 2021
@anushadatar anushadatar added the wontfix This will not be worked on label Mar 12, 2021
@anushadatar
Copy link
Contributor Author

While this fix would be a nice enhancement, I think it should probably be among the lowest priority given timeline for transitioning this project; documentation is a lot more important than nice tooling. Marking as wontfix for now, but if anyone else wants to take it on they can of course.

@anushadatar anushadatar removed the wontfix This will not be worked on label Mar 12, 2021
@anushadatar
Copy link
Contributor Author

log_and_switch has some logging functionality if you need an example: https://github.com/airpartners/logger/blob/master/log-and-switch.py

@anushadatar anushadatar changed the title Add DEBUG option to serialdevices class, and set test scripts to default to using this. Add logging to the serialdevices class to facilitate debugging. Mar 17, 2021
@anushadatar
Copy link
Contributor Author

This should be off by default on the systemd-called implementation, we don't want logs to fill up the disk on the raspi or cause some other problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant