Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map view interaction not connected to data refresh or navbar #18

Open
ljordan51 opened this issue Jul 7, 2020 · 0 comments
Open

map view interaction not connected to data refresh or navbar #18

ljordan51 opened this issue Jul 7, 2020 · 0 comments

Comments

@ljordan51
Copy link
Contributor

The data is refreshed with useEffect hooks in CotentContainer. When a user clicks different locations on the map, they move that location into focus but the route stays the same so ContentContainer never runs its useEffect hook to update the data for the active location if needed. Even if it did, all the others would stay stale until clicked on which isn't the best UX (we don't want it to change as soon as you click on it. This will all become irrelevant if we use the realtime db to push updates to the app instead of having the app request data every XX minutes (currently 5). Additionally, it would improve UX if the navbar updated it's highlight on the active location when clicked on the map because right now there is no display of the name of the currently focused location in the map.

Steps to recreate:

  1. Go to https://airpartners-ade.web.app/SN000-067/Map
  2. Click several other little arrows at the other sensor locations.
  3. Observe the route not changing. Observe the navbar highlight not changing.
  4. Leave the webpage idle for at least 5 minutes. Click around again and observe no WebSocket activity in the JS console.
  5. Click a location on the navbar that changes to the url path and observe a delay while the data is fetched and/or observe WebSocket activity in the JS console.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant