Pass signals to the launcher command from the wrapper script #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electrum
reviewed
Nov 30, 2024
electrum
approved these changes
Nov 30, 2024
nineinchnick
force-pushed
the
signals
branch
from
14348e0 to
bff9592
Compare
Without this, if the launcher is used in a Docker container, the container will never terminate gracefully.
nineinchnick
force-pushed
the
signals
branch
from
bff9592 to
956b97b
Compare
|
@martint can you release a new version with this change? It's needed in Trino to fix graceful shutdown. |
|
Will do that today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, if the launcher is used in a Docker container, the container will never terminate gracefully.
I tested this manually in Trino 466, which is affected by this behavior.