From b0c20ef7fa6710a6eadbcac59e8141aa8d703d29 Mon Sep 17 00:00:00 2001 From: Brian Storti Date: Wed, 11 Sep 2024 15:42:15 -0300 Subject: [PATCH] Use `crossorigin="use-credentials"` for manifest files When running Airbyte behind an authentication proxy (in my case, GCP's Identity-Aware Proxy), the `manifest.json` request will always fail with a CORS error, like: ``` Access to manifest at 'https://accounts.google.com/o/oauth2/v2/auth?client_id=465372...' (redirected from 'https://airbyte.mydomain.com/manifest.json') from origin 'https://airbyte.mydomain.com' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. ``` --- airbyte-webapp/index.html | 2 +- airbyte-webapp/oauth-callback.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/airbyte-webapp/index.html b/airbyte-webapp/index.html index 2fe5c378156..6a684e00f36 100644 --- a/airbyte-webapp/index.html +++ b/airbyte-webapp/index.html @@ -12,7 +12,7 @@ - + Airbyte diff --git a/airbyte-webapp/oauth-callback.html b/airbyte-webapp/oauth-callback.html index db2717cb410..921a85c5fe7 100644 --- a/airbyte-webapp/oauth-callback.html +++ b/airbyte-webapp/oauth-callback.html @@ -12,7 +12,7 @@ - + Airbyte