Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Values used to calculate reward is also the observation of the agent #8

Open
sunchaesk opened this issue May 26, 2023 · 0 comments
Open
Labels
question Further information is requested

Comments

@sunchaesk
Copy link

Not an error of the program, but one thing I noticed is that the obs: dict contains both the variables and the meters, and the function _compute_reward(), uses the values of the obs dictionary.

So the agent uses the meter to compute the reward but also the same meters are passed into the agent as observation.

I'm not sure but I was thinking this could potentially lead to some problems, maybe biased learning?

@antoine-galataud antoine-galataud added the question Further information is requested label Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants