Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

last commit error #120

Open
thegodone opened this issue Dec 8, 2023 · 6 comments
Open

last commit error #120

thegodone opened this issue Dec 8, 2023 · 6 comments

Comments

@thegodone
Copy link
Contributor

training % python3 train_graph.py --hyper hyper/hyper_esol.py --category GIN

Traceback (most recent call last):
File "/Users/tgg/Github/gcnn_keras4/training/train_graph.py", line 9, in
import kgcnn.losses.losses
ModuleNotFoundError: No module named 'kgcnn.losses'

I've updated github last code and only comment "pyxtal>=0.5.5" installation in the setup.py file (it needs pyshtools installation not compatible with Apple Silicon system).

@PatReis
Copy link
Collaborator

PatReis commented Dec 8, 2023

Hello, thanks.
I am sorry, but I do not understand the error. The module should be there: https://github.com/aimat-lab/gcnn_keras/tree/master/kgcnn/losses
Is it really the latest git version? I am not yet finished with version 4.0. So it is not available on pip yet.
Can you check the installation agian?

@thegodone
Copy link
Contributor Author

thegodone commented Dec 8, 2023 via email

@PatReis
Copy link
Collaborator

PatReis commented Dec 11, 2023

The last version would be 3.1.0 but I do not think that current trainng scripts will work with 3.1.0.
The step to keras 3 is actually quite substantial. Do you know what exactly does not work with keras 3?
Is it the tensorflow version ?

@PatReis
Copy link
Collaborator

PatReis commented Dec 12, 2023

If you want I can update your scripts to kgcnn 4 and keras 3.

@PatReis
Copy link
Collaborator

PatReis commented Dec 20, 2023

I think keras 3.0 should be fine for all OS. You can install an older tensorflow version like e.g. 2.14 which installs keras 2.
But then you can uninstall keras and install keras 3 without chaning tensorflow. Keras 3.0 worked also with tensorflow 2.14 as far as I can tell.

@thegodone
Copy link
Contributor Author

I changed two things basically and now it works for tf 2.15 / v3.1.0

# from kgcnn.utils.models   
from kgcnn.model.utils import get_model_class # kgcnn.utils.models decrepeated starting 2.2.4
from kgcnn.molecule.encoder import OneHotEncoder # remove starting 3.0.1
from kgcnn.training.hyper import HyperParameter # moved from hyper to training

@thegodone thegodone reopened this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants