forked from google/syzkaller
-
Notifications
You must be signed in to change notification settings - Fork 0
/
reporting.go
1207 lines (1151 loc) · 36.8 KB
/
reporting.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
// Copyright 2017 syzkaller project authors. All rights reserved.
// Use of this source code is governed by Apache 2 LICENSE that can be found in the LICENSE file.
package main
import (
"bytes"
"encoding/json"
"fmt"
"reflect"
"sort"
"strings"
"time"
"github.com/google/syzkaller/dashboard/dashapi"
"github.com/google/syzkaller/pkg/email"
"github.com/google/syzkaller/pkg/html"
"github.com/google/syzkaller/sys/targets"
"golang.org/x/net/context"
db "google.golang.org/appengine/datastore"
"google.golang.org/appengine/log"
)
// Backend-independent reporting logic.
// Two main entry points:
// - reportingPoll is called by backends to get list of bugs that need to be reported.
// - incomingCommand is called by backends to update bug statuses.
const (
maxMailReportLen = 64 << 10
maxInlineError = 16 << 10
notifyResendPeriod = 14 * 24 * time.Hour
notifyAboutBadCommitPeriod = 90 * 24 * time.Hour
never = 100 * 365 * 24 * time.Hour
internalError = "internal error"
// This is embedded as first line of syzkaller reproducer files.
syzReproPrefix = "# See https://goo.gl/kgGztJ for information about syzkaller reproducers.\n"
)
// reportingPoll is called by backends to get list of bugs that need to be reported.
func reportingPollBugs(c context.Context, typ string) []*dashapi.BugReport {
state, err := loadReportingState(c)
if err != nil {
log.Errorf(c, "%v", err)
return nil
}
bugs, _, err := loadOpenBugs(c)
if err != nil {
log.Errorf(c, "%v", err)
return nil
}
log.Infof(c, "fetched %v bugs", len(bugs))
sort.Sort(bugReportSorter(bugs))
var reports []*dashapi.BugReport
for _, bug := range bugs {
rep, err := handleReportBug(c, typ, state, bug)
if err != nil {
log.Errorf(c, "%v: failed to report bug %v: %v", bug.Namespace, bug.Title, err)
continue
}
if rep == nil {
continue
}
reports = append(reports, rep)
// Trying to report too many at once is known to cause OOMs.
// But new bugs appear incrementally and polling is frequent enough,
// so reporting lots of bugs at once is also not necessary.
if len(reports) == 3 {
break
}
}
return reports
}
func handleReportBug(c context.Context, typ string, state *ReportingState, bug *Bug) (
*dashapi.BugReport, error) {
reporting, bugReporting, crash, crashKey, _, _, _, err := needReport(c, typ, state, bug)
if err != nil || reporting == nil {
return nil, err
}
rep, err := createBugReport(c, bug, crash, crashKey, bugReporting, reporting)
if err != nil {
return nil, err
}
log.Infof(c, "bug %q: reporting to %v", bug.Title, reporting.Name)
return rep, nil
}
func needReport(c context.Context, typ string, state *ReportingState, bug *Bug) (
reporting *Reporting, bugReporting *BugReporting, crash *Crash,
crashKey *db.Key, reportingIdx int, status, link string, err error) {
reporting, bugReporting, reportingIdx, status, err = currentReporting(c, bug)
if err != nil || reporting == nil {
return
}
if typ != "" && typ != reporting.Config.Type() {
status = "on a different reporting"
reporting, bugReporting = nil, nil
return
}
link = bugReporting.Link
if !bugReporting.Reported.IsZero() && bugReporting.ReproLevel >= bug.ReproLevel {
status = fmt.Sprintf("%v: reported%v on %v",
reporting.DisplayTitle, reproStr(bugReporting.ReproLevel),
html.FormatTime(bugReporting.Reported))
reporting, bugReporting = nil, nil
return
}
ent := state.getEntry(timeNow(c), bug.Namespace, reporting.Name)
cfg := config.Namespaces[bug.Namespace]
if timeSince(c, bug.FirstTime) < cfg.ReportingDelay {
status = fmt.Sprintf("%v: initial reporting delay", reporting.DisplayTitle)
reporting, bugReporting = nil, nil
return
}
if bug.ReproLevel < ReproLevelC && timeSince(c, bug.FirstTime) < cfg.WaitForRepro {
status = fmt.Sprintf("%v: waiting for C repro", reporting.DisplayTitle)
reporting, bugReporting = nil, nil
return
}
if !cfg.MailWithoutReport && !bug.HasReport {
status = fmt.Sprintf("%v: no report", reporting.DisplayTitle)
reporting, bugReporting = nil, nil
return
}
crash, crashKey, err = findCrashForBug(c, bug)
if err != nil {
status = fmt.Sprintf("%v: no crashes!", reporting.DisplayTitle)
reporting, bugReporting = nil, nil
return
}
// Limit number of reports sent per day,
// but don't limit sending repros to already reported bugs.
if bugReporting.Reported.IsZero() && ent.Sent >= reporting.DailyLimit {
status = fmt.Sprintf("%v: out of quota for today", reporting.DisplayTitle)
reporting, bugReporting = nil, nil
return
}
// Ready to be reported.
if bugReporting.Reported.IsZero() {
// This update won't be committed, but it is useful as a best effort measure
// so that we don't overflow the limit in a single poll.
ent.Sent++
}
status = fmt.Sprintf("%v: ready to report", reporting.DisplayTitle)
if !bugReporting.Reported.IsZero() {
status += fmt.Sprintf(" (reported%v on %v)",
reproStr(bugReporting.ReproLevel), html.FormatTime(bugReporting.Reported))
}
return
}
func reportingPollNotifications(c context.Context, typ string) []*dashapi.BugNotification {
bugs, _, err := loadOpenBugs(c)
if err != nil {
log.Errorf(c, "%v", err)
return nil
}
log.Infof(c, "fetched %v bugs", len(bugs))
var notifs []*dashapi.BugNotification
for _, bug := range bugs {
if config.Namespaces[bug.Namespace].Decommissioned {
continue
}
notif, err := handleReportNotif(c, typ, bug)
if err != nil {
log.Errorf(c, "%v: failed to create bug notif %v: %v", bug.Namespace, bug.Title, err)
continue
}
if notif == nil {
continue
}
notifs = append(notifs, notif)
if len(notifs) >= 10 {
break // don't send too many at once just in case
}
}
return notifs
}
func handleReportNotif(c context.Context, typ string, bug *Bug) (*dashapi.BugNotification, error) {
reporting, bugReporting, _, _, err := currentReporting(c, bug)
if err != nil || reporting == nil {
return nil, nil
}
if typ != "" && typ != reporting.Config.Type() {
return nil, nil
}
if bug.Status != BugStatusOpen || bugReporting.Reported.IsZero() {
return nil, nil
}
if reporting.moderation &&
reporting.Embargo != 0 &&
len(bug.Commits) == 0 &&
bugReporting.OnHold.IsZero() &&
timeSince(c, bugReporting.Reported) > reporting.Embargo {
log.Infof(c, "%v: upstreaming (embargo): %v", bug.Namespace, bug.Title)
return createNotification(c, dashapi.BugNotifUpstream, true, "", bug, reporting, bugReporting)
}
if reporting.moderation &&
len(bug.Commits) == 0 &&
bugReporting.OnHold.IsZero() &&
reporting.Filter(bug) == FilterSkip {
log.Infof(c, "%v: upstreaming (skip): %v", bug.Namespace, bug.Title)
return createNotification(c, dashapi.BugNotifUpstream, true, "", bug, reporting, bugReporting)
}
if len(bug.Commits) == 0 &&
bug.wontBeFixBisected() &&
timeSince(c, bug.LastActivity) > notifyResendPeriod &&
timeSince(c, bug.LastTime) > bug.obsoletePeriod() {
log.Infof(c, "%v: obsoleting: %v", bug.Namespace, bug.Title)
return createNotification(c, dashapi.BugNotifObsoleted, false, "", bug, reporting, bugReporting)
}
if len(bug.Commits) > 0 &&
len(bug.PatchedOn) == 0 &&
timeSince(c, bug.LastActivity) > notifyResendPeriod &&
timeSince(c, bug.FixTime) > notifyAboutBadCommitPeriod {
log.Infof(c, "%v: bad fix commit: %v", bug.Namespace, bug.Title)
commits := strings.Join(bug.Commits, "\n")
return createNotification(c, dashapi.BugNotifBadCommit, true, commits, bug, reporting, bugReporting)
}
return nil, nil
}
// TODO: this is what we would like to do, but we need to figure out
// KMSAN story: we don't do fix bisection on it (rebased),
// do we want to close all old KMSAN bugs with repros?
// For now we only enable this in tests.
var obsoleteWhatWontBeFixBisected = false
func (bug *Bug) wontBeFixBisected() bool {
if bug.ReproLevel == ReproLevelNone {
return true
}
if obsoleteWhatWontBeFixBisected {
cfg := config.Namespaces[bug.Namespace]
for _, mgr := range bug.HappenedOn {
if !cfg.Managers[mgr].FixBisectionDisabled {
return false
}
}
return true
}
return false
}
func (bug *Bug) obsoletePeriod() time.Duration {
period := never
if config.Obsoleting.MinPeriod == 0 {
return period
}
// Before we have at least 10 crashes, any estimation of frequency is too imprecise.
// In such case we conservatively assume it still happens.
if bug.NumCrashes >= 10 {
// This is linear extrapolation for when the next crash should happen.
period = bug.LastTime.Sub(bug.FirstTime) / time.Duration(bug.NumCrashes-1)
// Let's be conservative with obsoleting too early.
period *= 100
}
min, max := config.Obsoleting.MinPeriod, config.Obsoleting.MaxPeriod
if config.Obsoleting.NonFinalMinPeriod != 0 &&
bug.Reporting[len(bug.Reporting)-1].Reported.IsZero() {
min, max = config.Obsoleting.NonFinalMinPeriod, config.Obsoleting.NonFinalMaxPeriod
}
if mgr := bug.managerConfig(); mgr != nil && mgr.ObsoletingMinPeriod != 0 {
min, max = mgr.ObsoletingMinPeriod, mgr.ObsoletingMaxPeriod
}
if period < min {
period = min
}
if period > max {
period = max
}
return period
}
func (bug *Bug) managerConfig() *ConfigManager {
if len(bug.HappenedOn) != 1 {
return nil
}
mgr := config.Namespaces[bug.Namespace].Managers[bug.HappenedOn[0]]
return &mgr
}
func createNotification(c context.Context, typ dashapi.BugNotif, public bool, text string, bug *Bug,
reporting *Reporting, bugReporting *BugReporting) (*dashapi.BugNotification, error) {
reportingConfig, err := json.Marshal(reporting.Config)
if err != nil {
return nil, err
}
crash, _, err := findCrashForBug(c, bug)
if err != nil {
return nil, fmt.Errorf("no crashes for bug")
}
build, err := loadBuild(c, bug.Namespace, crash.BuildID)
if err != nil {
return nil, err
}
kernelRepo := kernelRepoInfo(build)
notif := &dashapi.BugNotification{
Type: typ,
Namespace: bug.Namespace,
Config: reportingConfig,
ID: bugReporting.ID,
ExtID: bugReporting.ExtID,
Title: bug.displayTitle(),
Text: text,
Public: public,
CC: kernelRepo.CC.Always,
}
if public {
notif.Maintainers = append(crash.Maintainers, kernelRepo.CC.Maintainers...)
}
if (public || reporting.moderation) && bugReporting.CC != "" {
notif.CC = append(notif.CC, strings.Split(bugReporting.CC, "|")...)
}
if mgr := bug.managerConfig(); mgr != nil {
notif.CC = append(notif.CC, mgr.CC.Always...)
if public {
notif.Maintainers = append(notif.Maintainers, mgr.CC.Maintainers...)
}
}
return notif, nil
}
func currentReporting(c context.Context, bug *Bug) (*Reporting, *BugReporting, int, string, error) {
for i := range bug.Reporting {
bugReporting := &bug.Reporting[i]
if !bugReporting.Closed.IsZero() {
continue
}
reporting := config.Namespaces[bug.Namespace].ReportingByName(bugReporting.Name)
if reporting == nil {
return nil, nil, 0, "", fmt.Errorf("%v: missing in config", bugReporting.Name)
}
if reporting.DailyLimit == 0 {
return nil, nil, 0, fmt.Sprintf("%v: reporting has daily limit 0", reporting.DisplayTitle), nil
}
switch reporting.Filter(bug) {
case FilterSkip:
if bugReporting.Reported.IsZero() {
continue
}
fallthrough
case FilterReport:
return reporting, bugReporting, i, "", nil
case FilterHold:
return nil, nil, 0, fmt.Sprintf("%v: reporting suspended", reporting.DisplayTitle), nil
}
}
return nil, nil, 0, "", fmt.Errorf("no reporting left")
}
func reproStr(level dashapi.ReproLevel) string {
switch level {
case ReproLevelSyz:
return " syz repro"
case ReproLevelC:
return " C repro"
default:
return ""
}
}
func createBugReport(c context.Context, bug *Bug, crash *Crash, crashKey *db.Key,
bugReporting *BugReporting, reporting *Reporting) (*dashapi.BugReport, error) {
reportingConfig, err := json.Marshal(reporting.Config)
if err != nil {
return nil, err
}
var job *Job
if bug.BisectCause == BisectYes || bug.BisectCause == BisectInconclusive || bug.BisectCause == BisectHorizont {
// If we have bisection results, report the crash/repro used for bisection.
job1, crash1, _, crashKey1, err := loadBisectJob(c, bug, JobBisectCause)
if err != nil {
return nil, err
}
job = job1
if crash1.ReproC != 0 || crash.ReproC == 0 {
// Don't override the crash in this case,
// otherwise we will always think that we haven't reported the C repro.
crash, crashKey = crash1, crashKey1
}
}
crashLog, _, err := getText(c, textCrashLog, crash.Log)
if err != nil {
return nil, err
}
report, _, err := getText(c, textCrashReport, crash.Report)
if err != nil {
return nil, err
}
if len(report) > maxMailReportLen {
report = report[:maxMailReportLen]
}
reproC, _, err := getText(c, textReproC, crash.ReproC)
if err != nil {
return nil, err
}
reproSyz, err := loadReproSyz(c, crash)
if err != nil {
return nil, err
}
machineInfo, _, err := getText(c, textMachineInfo, crash.MachineInfo)
if err != nil {
return nil, err
}
build, err := loadBuild(c, bug.Namespace, crash.BuildID)
if err != nil {
return nil, err
}
typ := dashapi.ReportNew
if !bugReporting.Reported.IsZero() {
typ = dashapi.ReportRepro
}
kernelRepo := kernelRepoInfo(build)
rep := &dashapi.BugReport{
Type: typ,
Config: reportingConfig,
ExtID: bugReporting.ExtID,
First: bugReporting.Reported.IsZero(),
Moderation: reporting.moderation,
Log: crashLog,
LogLink: externalLink(c, textCrashLog, crash.Log),
Report: report,
ReportLink: externalLink(c, textCrashReport, crash.Report),
CC: kernelRepo.CC.Always,
Maintainers: append(crash.Maintainers, kernelRepo.CC.Maintainers...),
ReproC: reproC,
ReproCLink: externalLink(c, textReproC, crash.ReproC),
ReproSyz: reproSyz,
ReproSyzLink: externalLink(c, textReproSyz, crash.ReproSyz),
ReproOpts: crash.ReproOpts,
MachineInfo: machineInfo,
MachineInfoLink: externalLink(c, textMachineInfo, crash.MachineInfo),
CrashID: crashKey.IntID(),
CrashTime: crash.Time,
NumCrashes: bug.NumCrashes,
HappenedOn: managersToRepos(c, bug.Namespace, bug.HappenedOn),
}
if bugReporting.CC != "" {
rep.CC = append(rep.CC, strings.Split(bugReporting.CC, "|")...)
}
if build.Type == BuildFailed {
rep.Maintainers = append(rep.Maintainers, kernelRepo.CC.BuildMaintainers...)
}
if mgr := bug.managerConfig(); mgr != nil {
rep.CC = append(rep.CC, mgr.CC.Always...)
rep.Maintainers = append(rep.Maintainers, mgr.CC.Maintainers...)
if build.Type == BuildFailed {
rep.Maintainers = append(rep.Maintainers, mgr.CC.BuildMaintainers...)
}
}
if job != nil {
rep.BisectCause = bisectFromJob(c, rep, job)
}
if err := fillBugReport(c, rep, bug, bugReporting, build); err != nil {
return nil, err
}
return rep, nil
}
func loadReproSyz(c context.Context, crash *Crash) ([]byte, error) {
reproSyz, _, err := getText(c, textReproSyz, crash.ReproSyz)
if err != nil || len(reproSyz) == 0 {
return nil, err
}
buf := new(bytes.Buffer)
buf.WriteString(syzReproPrefix)
if len(crash.ReproOpts) != 0 {
fmt.Fprintf(buf, "#%s\n", crash.ReproOpts)
}
buf.Write(reproSyz)
return buf.Bytes(), nil
}
// fillBugReport fills common report fields for bug and job reports.
func fillBugReport(c context.Context, rep *dashapi.BugReport, bug *Bug, bugReporting *BugReporting,
build *Build) error {
kernelConfig, _, err := getText(c, textKernelConfig, build.KernelConfig)
if err != nil {
return err
}
creditEmail, err := email.AddAddrContext(ownEmail(c), bugReporting.ID)
if err != nil {
return err
}
switch bug.Status {
case BugStatusOpen:
rep.BugStatus = dashapi.BugStatusOpen
case BugStatusFixed:
rep.BugStatus = dashapi.BugStatusFixed
case BugStatusInvalid:
rep.BugStatus = dashapi.BugStatusInvalid
case BugStatusDup:
rep.BugStatus = dashapi.BugStatusDup
default:
return fmt.Errorf("unknown bugs status %v", bug.Status)
}
rep.Namespace = bug.Namespace
rep.ID = bugReporting.ID
rep.Title = bug.displayTitle()
rep.Link = fmt.Sprintf("%v/bug?extid=%v", appURL(c), bugReporting.ID)
rep.CreditEmail = creditEmail
rep.OS = build.OS
rep.Arch = build.Arch
rep.VMArch = build.VMArch
rep.UserSpaceArch = kernelArch(build.Arch)
rep.BuildID = build.ID
rep.BuildTime = build.Time
rep.CompilerID = build.CompilerID
rep.KernelRepo = build.KernelRepo
rep.KernelRepoAlias = kernelRepoInfo(build).Alias
rep.KernelBranch = build.KernelBranch
rep.KernelCommit = build.KernelCommit
rep.KernelCommitTitle = build.KernelCommitTitle
rep.KernelCommitDate = build.KernelCommitDate
rep.KernelConfig = kernelConfig
rep.KernelConfigLink = externalLink(c, textKernelConfig, build.KernelConfig)
rep.SyzkallerCommit = build.SyzkallerCommit
rep.NoRepro = build.Type == BuildFailed
for _, addr := range bug.UNCC {
rep.CC = email.RemoveFromEmailList(rep.CC, addr)
rep.Maintainers = email.RemoveFromEmailList(rep.Maintainers, addr)
}
return nil
}
func loadBisectJob(c context.Context, bug *Bug, jobType JobType) (*Job, *Crash, *db.Key, *db.Key, error) {
bugKey := bug.key(c)
var jobs []*Job
keys, err := db.NewQuery("Job").
Ancestor(bugKey).
Filter("Type=", jobType).
Filter("Finished>", time.Time{}).
Order("-Finished").
Limit(1).
GetAll(c, &jobs)
if err != nil {
return nil, nil, nil, nil, fmt.Errorf("failed to query jobs: %v", err)
}
if len(jobs) == 0 {
jobStr := map[JobType]string{
JobBisectCause: "bisect cause",
JobBisectFix: "bisect fix",
}
return nil, nil, nil, nil, fmt.Errorf("can't find %s job for bug", jobStr[jobType])
}
job := jobs[0]
crash := new(Crash)
crashKey := db.NewKey(c, "Crash", "", job.CrashID, bugKey)
if err := db.Get(c, crashKey, crash); err != nil {
return nil, nil, nil, nil, fmt.Errorf("failed to get crash: %v", err)
}
return job, crash, keys[0], crashKey, nil
}
func managersToRepos(c context.Context, ns string, managers []string) []string {
var repos []string
dedup := make(map[string]bool)
for _, manager := range managers {
build, err := lastManagerBuild(c, ns, manager)
if err != nil {
log.Errorf(c, "failed to get manager %q build: %v", manager, err)
continue
}
repo := kernelRepoInfo(build).Alias
if dedup[repo] {
continue
}
dedup[repo] = true
repos = append(repos, repo)
}
sort.Strings(repos)
return repos
}
func loadAllBugs(c context.Context, filter func(*db.Query) *db.Query) ([]*Bug, []*db.Key, error) {
var bugs []*Bug
var keys []*db.Key
err := foreachBug(c, filter, func(bug *Bug, key *db.Key) error {
bugs = append(bugs, bug)
keys = append(keys, key)
return nil
})
if err != nil {
return nil, nil, err
}
return bugs, keys, nil
}
func loadNamespaceBugs(c context.Context, ns string) ([]*Bug, []*db.Key, error) {
return loadAllBugs(c, func(query *db.Query) *db.Query {
return query.Filter("Namespace=", ns)
})
}
func loadOpenBugs(c context.Context) ([]*Bug, []*db.Key, error) {
return loadAllBugs(c, func(query *db.Query) *db.Query {
return query.Filter("Status<", BugStatusFixed)
})
}
func foreachBug(c context.Context, filter func(*db.Query) *db.Query, fn func(bug *Bug, key *db.Key) error) error {
const batchSize = 1000
var cursor *db.Cursor
for {
query := db.NewQuery("Bug").Limit(batchSize)
if filter != nil {
query = filter(query)
}
if cursor != nil {
query = query.Start(*cursor)
}
iter := query.Run(c)
for i := 0; ; i++ {
bug := new(Bug)
key, err := iter.Next(bug)
if err == db.Done {
if i < batchSize {
return nil
}
break
}
if err != nil {
return fmt.Errorf("failed to fetch bugs: %v", err)
}
if err := fn(bug, key); err != nil {
return err
}
}
cur, err := iter.Cursor()
if err != nil {
return fmt.Errorf("cursor failed while fetching bugs: %v", err)
}
cursor = &cur
}
}
// reportingPollClosed is called by backends to get list of closed bugs.
func reportingPollClosed(c context.Context, ids []string) ([]string, error) {
idMap := make(map[string]bool, len(ids))
for _, id := range ids {
idMap[id] = true
}
var closed []string
err := foreachBug(c, nil, func(bug *Bug, _ *db.Key) error {
for i := range bug.Reporting {
bugReporting := &bug.Reporting[i]
if !idMap[bugReporting.ID] {
continue
}
var err error
bug, err = canonicalBug(c, bug)
if err != nil {
log.Errorf(c, "%v", err)
break
}
if bug.Status >= BugStatusFixed || !bugReporting.Closed.IsZero() {
closed = append(closed, bugReporting.ID)
}
break
}
return nil
})
return closed, err
}
// incomingCommand is entry point to bug status updates.
func incomingCommand(c context.Context, cmd *dashapi.BugUpdate) (bool, string, error) {
log.Infof(c, "got command: %+v", cmd)
ok, reason, err := incomingCommandImpl(c, cmd)
if err != nil {
log.Errorf(c, "%v (%v)", reason, err)
} else if !ok && reason != "" {
log.Errorf(c, "invalid update: %v", reason)
}
return ok, reason, err
}
func incomingCommandImpl(c context.Context, cmd *dashapi.BugUpdate) (bool, string, error) {
for i, com := range cmd.FixCommits {
if len(com) >= 2 && com[0] == '"' && com[len(com)-1] == '"' {
com = com[1 : len(com)-1]
cmd.FixCommits[i] = com
}
if len(com) < 3 {
return false, fmt.Sprintf("bad commit title: %q", com), nil
}
}
bug, bugKey, err := findBugByReportingID(c, cmd.ID)
if err != nil {
return false, internalError, err
}
var dupKey *db.Key
if cmd.Status == dashapi.BugStatusDup {
if looksLikeReportingHash(cmd.DupOf) {
_, dupKey, _ = findBugByReportingID(c, cmd.DupOf)
}
if dupKey == nil {
// Email reporting passes bug title in cmd.DupOf, try to find bug by title.
var dup *Bug
dup, dupKey, err = findDupByTitle(c, bug.Namespace, cmd.DupOf)
if err != nil || dup == nil {
return false, "can't find the dup bug", err
}
dupReporting := lastReportedReporting(dup)
if dupReporting == nil {
return false, "can't find the dup bug", fmt.Errorf("dup does not have reporting")
}
cmd.DupOf = dupReporting.ID
}
}
now := timeNow(c)
ok, reply := false, ""
tx := func(c context.Context) error {
var err error
ok, reply, err = incomingCommandTx(c, now, cmd, bugKey, dupKey)
return err
}
err = db.RunInTransaction(c, tx, &db.TransactionOptions{
XG: true,
// Default is 3 which fails sometimes.
// We don't want incoming bug updates to fail,
// because for e.g. email we won't have an external retry.
Attempts: 30,
})
if err != nil {
return false, internalError, err
}
return ok, reply, nil
}
func checkDupBug(c context.Context, cmd *dashapi.BugUpdate, bug *Bug, bugKey, dupKey *db.Key) (
*Bug, bool, string, error) {
dup := new(Bug)
if err := db.Get(c, dupKey, dup); err != nil {
return nil, false, internalError, fmt.Errorf("can't find the dup by key: %v", err)
}
bugReporting, _ := bugReportingByID(bug, cmd.ID)
dupReporting, _ := bugReportingByID(dup, cmd.DupOf)
if bugReporting == nil || dupReporting == nil {
return nil, false, internalError, fmt.Errorf("can't find bug reporting")
}
if bugKey.StringID() == dupKey.StringID() {
if bugReporting.Name == dupReporting.Name {
return nil, false, "Can't dup bug to itself.", nil
}
return nil, false, fmt.Sprintf("Can't dup bug to itself in different reporting (%v->%v).\n"+
"Please dup syzbot bugs only onto syzbot bugs for the same kernel/reporting.",
bugReporting.Name, dupReporting.Name), nil
}
if bug.Namespace != dup.Namespace {
return nil, false, fmt.Sprintf("Duplicate bug corresponds to a different kernel (%v->%v).\n"+
"Please dup syzbot bugs only onto syzbot bugs for the same kernel.",
bug.Namespace, dup.Namespace), nil
}
if !allowCrossReportingDup(c, bug, dup, bugReporting, dupReporting) {
return nil, false, fmt.Sprintf("Can't dup bug to a bug in different reporting (%v->%v)."+
"Please dup syzbot bugs only onto syzbot bugs for the same kernel/reporting.",
bugReporting.Name, dupReporting.Name), nil
}
dupCanon, err := canonicalBug(c, dup)
if err != nil {
return nil, false, internalError, fmt.Errorf("failed to get canonical bug for dup: %v", err)
}
if !dupReporting.Closed.IsZero() && dupCanon.Status == BugStatusOpen {
return nil, false, "Dup bug is already upstreamed.", nil
}
if dupCanon.keyHash() == bugKey.StringID() {
return nil, false, "Setting this dup would lead to a bug cycle, cycles are not allowed.", nil
}
return dup, true, "", nil
}
func allowCrossReportingDup(c context.Context, bug, dup *Bug,
bugReporting, dupReporting *BugReporting) bool {
bugIdx := getReportingIdx(c, bug, bugReporting)
dupIdx := getReportingIdx(c, dup, dupReporting)
if bugIdx < 0 || dupIdx < 0 {
return false
}
if bugIdx == dupIdx {
return true
}
// We generally allow duping only within the same reporting.
// But there is one exception: we also allow duping from last but one
// reporting to the last one (which is stable, final destination)
// provided that these two reportings have the same access level and type.
// The rest of the combinations can lead to surprising states and
// information hiding, so we don't allow them.
cfg := config.Namespaces[bug.Namespace]
bugConfig := &cfg.Reporting[bugIdx]
dupConfig := &cfg.Reporting[dupIdx]
lastIdx := len(cfg.Reporting) - 1
return bugIdx == lastIdx-1 && dupIdx == lastIdx &&
bugConfig.AccessLevel == dupConfig.AccessLevel &&
bugConfig.Config.Type() == dupConfig.Config.Type()
}
func getReportingIdx(c context.Context, bug *Bug, bugReporting *BugReporting) int {
for i := range bug.Reporting {
if bug.Reporting[i].Name == bugReporting.Name {
return i
}
}
log.Errorf(c, "failed to find bug reporting by name: %q/%q", bug.Title, bugReporting.Name)
return -1
}
func incomingCommandTx(c context.Context, now time.Time, cmd *dashapi.BugUpdate, bugKey, dupKey *db.Key) (
bool, string, error) {
bug := new(Bug)
if err := db.Get(c, bugKey, bug); err != nil {
return false, internalError, fmt.Errorf("can't find the corresponding bug: %v", err)
}
var dup *Bug
if cmd.Status == dashapi.BugStatusDup {
dup1, ok, reason, err := checkDupBug(c, cmd, bug, bugKey, dupKey)
if !ok || err != nil {
return ok, reason, err
}
dup = dup1
}
state, err := loadReportingState(c)
if err != nil {
return false, internalError, err
}
ok, reason, err := incomingCommandUpdate(c, now, cmd, bugKey, bug, dup, state)
if !ok || err != nil {
return ok, reason, err
}
if _, err := db.Put(c, bugKey, bug); err != nil {
return false, internalError, fmt.Errorf("failed to put bug: %v", err)
}
if err := saveReportingState(c, state); err != nil {
return false, internalError, err
}
return true, "", nil
}
func incomingCommandUpdate(c context.Context, now time.Time, cmd *dashapi.BugUpdate, bugKey *db.Key,
bug, dup *Bug, state *ReportingState) (bool, string, error) {
bugReporting, final := bugReportingByID(bug, cmd.ID)
if bugReporting == nil {
return false, internalError, fmt.Errorf("can't find bug reporting")
}
if ok, reply, err := checkBugStatus(c, cmd, bug, bugReporting); !ok {
return false, reply, err
}
stateEnt := state.getEntry(now, bug.Namespace, bugReporting.Name)
if ok, reply, err := incomingCommandCmd(c, now, cmd, bug, dup, bugReporting, final, stateEnt); !ok {
return false, reply, err
}
if (len(cmd.FixCommits) != 0 || cmd.ResetFixCommits) &&
(bug.Status == BugStatusOpen || bug.Status == BugStatusDup) {
sort.Strings(cmd.FixCommits)
if !reflect.DeepEqual(bug.Commits, cmd.FixCommits) {
bug.updateCommits(cmd.FixCommits, now)
}
}
if cmd.CrashID != 0 {
// Rememeber that we've reported this crash.
if err := markCrashReported(c, cmd.CrashID, bugKey, now); err != nil {
return false, internalError, err
}
bugReporting.CrashID = cmd.CrashID
}
if bugReporting.ExtID == "" {
bugReporting.ExtID = cmd.ExtID
}
if bugReporting.Link == "" {
bugReporting.Link = cmd.Link
}
if len(cmd.CC) != 0 && cmd.Status != dashapi.BugStatusUnCC {
merged := email.MergeEmailLists(strings.Split(bugReporting.CC, "|"), cmd.CC)
bugReporting.CC = strings.Join(merged, "|")
}
if bugReporting.ReproLevel < cmd.ReproLevel {
bugReporting.ReproLevel = cmd.ReproLevel
}
if bug.Status != BugStatusDup {
bug.DupOf = ""
}
if cmd.Status != dashapi.BugStatusOpen || !cmd.OnHold {
bugReporting.OnHold = time.Time{}
}
bug.LastActivity = now
return true, "", nil
}
func incomingCommandCmd(c context.Context, now time.Time, cmd *dashapi.BugUpdate, bug, dup *Bug,
bugReporting *BugReporting, final bool, stateEnt *ReportingStateEntry) (bool, string, error) {
switch cmd.Status {
case dashapi.BugStatusOpen:
bug.Status = BugStatusOpen
bug.Closed = time.Time{}
if bugReporting.Reported.IsZero() {
bugReporting.Reported = now
stateEnt.Sent++ // sending repro does not count against the quota
}
if bugReporting.OnHold.IsZero() && cmd.OnHold {
bugReporting.OnHold = now
}
// Close all previous reporting if they are not closed yet
// (can happen due to Status == ReportingDisabled).
for i := range bug.Reporting {
if bugReporting == &bug.Reporting[i] {
break
}
if bug.Reporting[i].Closed.IsZero() {
bug.Reporting[i].Closed = now
}
}
if bug.ReproLevel < cmd.ReproLevel {
return false, internalError,
fmt.Errorf("bug update with invalid repro level: %v/%v",
bug.ReproLevel, cmd.ReproLevel)
}
case dashapi.BugStatusUpstream:
if final {
return false, "Can't upstream, this is final destination.", nil
}
if len(bug.Commits) != 0 {
// We could handle this case, but how/when it will occur
// in real life is unclear now.
return false, "Can't upstream this bug, the bug has fixing commits.", nil
}
bug.Status = BugStatusOpen
bug.Closed = time.Time{}
bugReporting.Closed = now
bugReporting.Auto = cmd.Notification
case dashapi.BugStatusInvalid:
bug.Closed = now
bug.Status = BugStatusInvalid
bugReporting.Closed = now
bugReporting.Auto = cmd.Notification
case dashapi.BugStatusDup:
bug.Status = BugStatusDup
bug.Closed = now
bug.DupOf = dup.keyHash()
case dashapi.BugStatusUpdate:
// Just update Link, Commits, etc below.
case dashapi.BugStatusUnCC:
bug.UNCC = email.MergeEmailLists(bug.UNCC, cmd.CC)
default:
return false, internalError, fmt.Errorf("unknown bug status %v", cmd.Status)
}
return true, "", nil
}
func checkBugStatus(c context.Context, cmd *dashapi.BugUpdate, bug *Bug, bugReporting *BugReporting) (
bool, string, error) {
switch bug.Status {
case BugStatusOpen:
case BugStatusDup:
canon, err := canonicalBug(c, bug)
if err != nil {
return false, internalError, err
}
if canon.Status != BugStatusOpen {
// We used to reject updates to closed bugs,
// but this is confusing and non-actionable for users.
// So now we fail the update, but give empty reason,
// which means "don't notify user".
if cmd.Status == dashapi.BugStatusUpdate {
// This happens when people discuss old bugs.
log.Infof(c, "Dup bug is already closed")
} else {
log.Errorf(c, "Dup bug is already closed")
}
return false, "", nil
}
case BugStatusFixed, BugStatusInvalid:
if cmd.Status != dashapi.BugStatusUpdate {
log.Errorf(c, "This bug is already closed")
}
return false, "", nil
default:
return false, internalError, fmt.Errorf("unknown bug status %v", bug.Status)
}
if !bugReporting.Closed.IsZero() {
if cmd.Status != dashapi.BugStatusUpdate {
log.Errorf(c, "This bug reporting is already closed")
}
return false, "", nil
}
return true, "", nil
}
func findBugByReportingID(c context.Context, id string) (*Bug, *db.Key, error) {
var bugs []*Bug
keys, err := db.NewQuery("Bug").
Filter("Reporting.ID=", id).
Limit(2).