Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

required:False does not apply when exposing outputs for a specification without namespace #269

Open
bastonero opened this issue May 19, 2023 · 0 comments

Comments

@bastonero
Copy link

plumpy behaves in the following when exposing outputs for a specification process (example as in AiiDA WorkChains):

  • Define a MainWorkChain
  • Using a SubWorkChain/SubCalcJob: spec.expose_outputs(SubWorkChain, namespace_options={'required': False})
  • MainChain.spec().outputs will still retain the required (True) outputs of SubWorkChain

The same doesn't happen when specifying a namespace in the expose_outputs.

Personal comments: I would expect as a plugin developer to actually override all required options of the exposed outputs, even when not defining a namespace. Otherwise, it seems pointless to specify the namespace_options if this does not happen (?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant