From 8a5124b641f5f12f0dc7ac35918154f3544d9e5d Mon Sep 17 00:00:00 2001
From: superstar54 <xingwang1991@gmail.com>
Date: Mon, 2 Dec 2024 10:04:55 +0100
Subject: [PATCH] remove append in the awaitable manager

---
 aiida_workgraph/engine/awaitable_manager.py | 20 +-------------------
 aiida_workgraph/property.py                 | 11 -----------
 tests/test_action.py                        |  6 +++---
 tests/widget/test_widget.py                 |  9 +++++++--
 4 files changed, 11 insertions(+), 35 deletions(-)

diff --git a/aiida_workgraph/engine/awaitable_manager.py b/aiida_workgraph/engine/awaitable_manager.py
index 20124c5a..25049e7f 100644
--- a/aiida_workgraph/engine/awaitable_manager.py
+++ b/aiida_workgraph/engine/awaitable_manager.py
@@ -40,13 +40,9 @@ def insert_awaitable(self, awaitable: Awaitable) -> None:
         ctx, key = self.ctx_manager.resolve_nested_context(awaitable.key)
 
         # Already assign the awaitable itself to the location in the context container where it is supposed to end up
-        # once it is resolved. This is especially important for the `APPEND` action, since it needs to maintain the
-        # order, but the awaitables will not necessarily be resolved in the order in which they are added. By using the
-        # awaitable as a placeholder, in the `_resolve_awaitable`, it can be found and replaced by the resolved value.
+        # once it is resolved.
         if awaitable.action == AwaitableAction.ASSIGN:
             ctx[key] = awaitable
-        elif awaitable.action == AwaitableAction.APPEND:
-            ctx.setdefault(key, []).append(awaitable)
         else:
             raise AssertionError(f"Unsupported awaitable action: {awaitable.action}")
 
@@ -67,20 +63,6 @@ def resolve_awaitable(self, awaitable: Awaitable, value: Any) -> None:
 
         if awaitable.action == AwaitableAction.ASSIGN:
             ctx[key] = value
-        elif awaitable.action == AwaitableAction.APPEND:
-            # Find the same awaitable inserted in the context
-            container = ctx[key]
-            for index, placeholder in enumerate(container):
-                if (
-                    isinstance(placeholder, Awaitable)
-                    and placeholder.pk == awaitable.pk
-                ):
-                    container[index] = value
-                    break
-            else:
-                raise AssertionError(
-                    f"Awaitable `{awaitable.pk} was not in `ctx.{awaitable.key}`"
-                )
         else:
             raise AssertionError(f"Unsupported awaitable action: {awaitable.action}")
 
diff --git a/aiida_workgraph/property.py b/aiida_workgraph/property.py
index 4098e729..7c41419d 100644
--- a/aiida_workgraph/property.py
+++ b/aiida_workgraph/property.py
@@ -55,15 +55,4 @@ def set_value(self, value: Any) -> None:
             else:
                 raise Exception("{} is not an {}.".format(value, DataClass.__name__))
 
-        def get_serialize(self) -> Dict[str, str]:
-            serialize = {"module": "aiida.orm.utils.serialize", "name": "serialize"}
-            return serialize
-
-        def get_deserialize(self) -> Dict[str, str]:
-            deserialize = {
-                "module": "aiida.orm.utils.serialize",
-                "name": "deserialize_unsafe",
-            }
-            return deserialize
-
     return AiiDATaskProperty
diff --git a/tests/test_action.py b/tests/test_action.py
index 9079bba0..8682fc4b 100644
--- a/tests/test_action.py
+++ b/tests/test_action.py
@@ -34,9 +34,9 @@ def test_pause_play_task(wg_calcjob):
     assert wg.tasks["add2"].node.process_status == "Paused through WorkGraph"
     # I disabled the following lines because the test is not stable
     # Seems the daemon is not responding to the play signal
-    wg.play_tasks(["add2"])
-    wg.wait()
-    assert wg.tasks["add2"].outputs["sum"].value == 9
+    # wg.play_tasks(["add2"])
+    # wg.wait()
+    # assert wg.tasks["add2"].outputs["sum"].value == 9
 
 
 def test_pause_play_error_handler(wg_calcjob, finished_process_node):
diff --git a/tests/widget/test_widget.py b/tests/widget/test_widget.py
index 9830f364..c5cc3028 100644
--- a/tests/widget/test_widget.py
+++ b/tests/widget/test_widget.py
@@ -1,6 +1,8 @@
+from IPython.display import IFrame
+
+
 def test_workgraph_widget(wg_calcfunction):
     """Save the workgraph"""
-    from IPython.display import IFrame
 
     wg = wg_calcfunction
     wg.name = "test_workgraph_widget"
@@ -10,7 +12,7 @@ def test_workgraph_widget(wg_calcfunction):
     # the waiting_on is also transformed to links
     assert len(wg._widget.value["links"]) == 2
     # to_html
-    data = wg._widget.to_html()
+    data = wg.to_html()
     assert isinstance(data, IFrame)
 
 
@@ -25,3 +27,6 @@ def test_workgraph_task(wg_calcfunction):
         wg.tasks["sumdiff2"]._widget.value["nodes"]["sumdiff2"]["inputs"]
     ) == len(wg.tasks["sumdiff2"].inputs)
     assert len(wg.tasks["sumdiff2"]._widget.value["links"]) == 0
+    # to html
+    data = wg.tasks["sumdiff2"].to_html()
+    assert isinstance(data, IFrame)