-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plan for a coding week #74
Comments
CC @giovannipizzi @ltalirz @unkcpz Let me know if the plan above sounds good, and please tag people who you know might be interested in this (and potentially available to review the PRs). |
What I would like to see is an integrated way to skip running a "mock code". Instead, I would like to get a calcjob node instance, which has the inputs and cached outputs connected to it. This could be used to unit test parsers, workchain logic etc. I've seen custom implementations for this in many plugins for testing parsers, including the two I (co-)authored, Having this integrated would be nice for two reasons:
|
You seem to be describing what Both the mock code and the I'll paste here what I wrote to Daniel in reply to his email, perhaps this can be integrated in the repo README Edit: Maybe I'm wrong about the "cannot test parsers" in === It solves it in two different ways, each of which have their pros and cons:
I do think that this use case continues to exist (aiida-vasp, ...) and requires a working solution. |
Thanks both! Just a note that I haven't made as much progress as I wanted as there's a lot of other stuff going on during the coding week, but I am interested in pursuing this beyond as well. I currently got stuck on trying to get the tests pass for newer aiida-core versions that had quite a few changes to caching infrastructure. I need to find more focused time to dig into the internals. One immediate thought that I had while digging through the implementation of the fixtures here: they seem to be mucking deep with the caching infrastructure of aiida-core, so even when I fix the issues with the new AiiDA versions, I am afraid that these fixtures would still be brittle. I see two ways to improve it:
I guess I am slightly leaning towards 2., since this repo has other stuff in it besides the fixtures (e.g. configuration management) so I don't know if it makes sense to integrate to aiida-core (at least not before things stabilize a bit). Anyway, this is just my morning rambling, at some point I'll turn this into a separate issue. |
Here's a rough plan for my work on this package during the AiiDA coding.
I'll see how far I'll get, since I also want to work on AiiDAlab related things.
This is the list of tasks, roughly in the order they need to be done
aiida-test-cache
consider name change #60mock_code
inaiida-orca
pluginarchive_cache
in ATMOSPEC AiiDAlab appThe text was updated successfully, but these errors were encountered: