Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developments not fully integrated yet #24

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mbercx
Copy link
Member

@mbercx mbercx commented Dec 4, 2024

Note: Comments below may be outdated, just opening a PR to check and share changes.

  1. Allow user to specify unique keys upon instantiation.
  2. Add order_by input which can be passed to the parent node query.
  3. Verbose submission now has a formatted table.

1. Allow user to specify unique keys upon instantiation.
2. Add `order_by` input which can be passed to the parent node query.
3. Verbose submission now has a formatted table.
@mbercx
Copy link
Member Author

mbercx commented Dec 4, 2024

Yup, seems some of the developments here have already been integrated. ^^ So this PR will most likely only be for the formatted table of the verbose submission.

Not sure if we should keep the changes regarding the exceptions... I don't like a bare Exception catch, so maybe it's good to be more specific, but not catching the exceptions is a pain.

@mbercx
Copy link
Member Author

mbercx commented Dec 4, 2024

Ah, seems the verbose table is also already integrated, now it's just duplicated 😂

So let's just think on the exceptions and maybe close this PR.

@mbercx mbercx force-pushed the main branch 3 times, most recently from 9aa909f to a564fe9 Compare December 10, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant