Import physical constants from qe-tools
instead of aiida-core
#388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69
The physical constants, mostly used by the parsers, used to be defined
in
aiida-core
for the Quantum ESPRESSO plugins, before they were movedto this repository. The physical constants remained, however, but will
be removed for
aiida-core==1.0.0
. The constants had already be copiedto
qe-tools
as well, which is where they will stay. Here we change theimport to use the constants from the latter instead of
aiida-core
.