Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the minimum_job_poll_interval from Computer to AuthInfo #3630

Open
giovannipizzi opened this issue Dec 10, 2019 · 2 comments
Open

Move the minimum_job_poll_interval from Computer to AuthInfo #3630

giovannipizzi opened this issue Dec 10, 2019 · 2 comments
Assignees
@giovannipizzi
Labels
design-issue A software design issue requires discussion topic/transports

Comments

@giovannipizzi
Copy link
Member

Currently, the minimum_job_poll_interval is set in the Computer metadata (this is the interval between running squeue commands).

I think this is a user setting more than a global computer feature, so this should go to the AuthInfo and be asked during the computer configure phase.

This might be partially related also the restructuring of Computer (#3616).

Also, when this is changed, please also update the corresponding documentation that is being merged in #3629
@giovannipizzi giovannipizzi added this to the v1.1.0 milestone Dec 10, 2019
@giovannipizzi giovannipizzi mentioned this issue Dec 10, 2019
Open
@ltalirz
Copy link
Member

ltalirz commented Dec 10, 2019

Makes complete sense.

@giovannipizzi giovannipizzi self-assigned this Dec 12, 2019
@giovannipizzi giovannipizzi mentioned this issue Dec 13, 2019
Closed
@sphuber sphuber removed this from the v1.1.0 milestone Feb 28, 2020
@giovannipizzi
Copy link
Member Author

Please check the discussion of the first tentative implementation in PR #3663, now closed - this contains a tentative, partial implementation, and some discussions, that should be helpful when addressing this issue.
To be addressed probably together with #3541

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giovannipizzi giovannipizzi

Labels
design-issue A software design issue requires discussion topic/transports
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrating configuration options to AuthInfo and redesigning the interface giovannipizzi/aiida-core
3 participants
@ltalirz @sphuber @giovannipizzi