Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new UNKNOWN type to ElectronicType #250

Closed
sphuber opened this issue Dec 7, 2021 · 0 comments · Fixed by #251
Closed

Add new UNKNOWN type to ElectronicType #250

sphuber opened this issue Dec 7, 2021 · 0 comments · Fixed by #251
Assignees

Comments

@sphuber
Copy link
Collaborator

sphuber commented Dec 7, 2021

The UNKNOWN type should indicate that the user doesn't know the electronic type of the material and the input generator should use inputs for a best guess. Typically this would be probably to treat the system as a metal with some smearing. The already existing type AUTOMATIC was being used for this purpose, but we want to reserve this option for the use case where the generator actually generates a builder for a workflow that will try and determine the electronic type through actual simulation. This may be too ambitious and it is not sure if this will be implemented in the future.

See for other discussions #211 and #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant