Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❓ QUESTION: Should BandsData also contain the Fermi level? #210

Open
mbercx opened this issue Jul 19, 2021 · 4 comments
Open

❓ QUESTION: Should BandsData also contain the Fermi level? #210

mbercx opened this issue Jul 19, 2021 · 4 comments
Labels
question Further information is requested topic/bands-dos Issues related to band structures or DOS

Comments

@mbercx
Copy link
Member

mbercx commented Jul 19, 2021

Currently the BandsData does not contain the Fermi level, as far as I know. Since this is quite an integral quantity to interpreting the band structure, and typically band structures are plotted by aligning the Fermi level to zero, maybe we should add the Fermi level to the BandsData as an attribute?

I think that for most codes, the calculation of the band structure involves the calculation of the charge density on a grid, so we can obtain the Fermi level from this step in the work chain?

A couple of side notes, unrelated to the common workflows:

  • One of the additional use cases for this would be the viewer widgets for AiiDAlab. Here typically the viewer just takes one node as an input, so currently the viewer widget for the band structure doesn't align the Fermi level to zero, making interpretation more difficult.
  • There is a move to using better representations of nodes for the aiida-core data types. I'd prefer to e.g. have a _repr_html_ method for the BandsData that automatically plots the band structure when it is returned in a Jupyter notebook. Here having the Fermi level available would also be a boon for these representations.

Once we've decided on this topic, we can migrate this issue to the aiida-core repo.

@mbercx mbercx added the question Further information is requested label Jul 19, 2021
@PhilippRue
Copy link

Coming from KKR calculations I am actually a bit surprised why the standard is not to measure energies relative to the Fermi level. After the self-consistency this should be known.

But maybe in other codes this is not so simple.

@bosonie
Copy link
Collaborator

bosonie commented Jul 21, 2021

Thanks for opening this issue. A related issue is already present in aiida-core. aiidateam/aiida-core#2847

The BandsData is also used for phonons and there are situation where also electronic bands are better not shifted to have the zero at the Fermi energy (Ef). However I agree that an optional attribute containing the Ef would be useful.

@giovannipizzi
Copy link
Member

I left some comments in aiidateam/aiida-core#2847

@sphuber
Copy link
Collaborator

sphuber commented Jul 28, 2021

See my comment on the relevant issue on aiida-core: aiidateam/aiida-core#2847 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested topic/bands-dos Issues related to band structures or DOS
Projects
None yet
Development

No branches or pull requests

5 participants