Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On clean remote data button and checks #857

Open
3 tasks
mikibonacci opened this issue Oct 10, 2024 · 0 comments
Open
3 tasks

On clean remote data button and checks #857

mikibonacci opened this issue Oct 10, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@mikibonacci
Copy link
Member

mikibonacci commented Oct 10, 2024

Improvements to be implemented:

  • We should check only once if the CalcJobNode are empty, not eveytime we load the page/workchain. Now, for each CalcJobNode, we check the is_empty attribute. We need to verify that this is does not open ssh connections each time is it accesssed (see if it is a property). If each time it connects to remote, we should instead store an extra is_empty in the workchain, and then we only check if this attribute is not set.
  • The clean button remains red even if it is disabled. We should change the color (grey).
  • We should somehow also estimate the size of the remote data, so the user can decide if delete or not. See this PR in aiida-core by @GeigerJ2 : ORM: Add get_size_on_disk method to RemoteData aiidateam/aiida-core#6584

This is a follow-up of #815

@mikibonacci mikibonacci added the enhancement New feature or request label Oct 10, 2024
@mikibonacci mikibonacci self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant