Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 IMPROVE: Minor layout and UX issues #53

Closed
19 tasks done
mbercx opened this issue May 11, 2021 · 1 comment · Fixed by #54
Closed
19 tasks done

👌 IMPROVE: Minor layout and UX issues #53

mbercx opened this issue May 11, 2021 · 1 comment · Fixed by #54
Assignees
Labels
enhancement New feature or request

Comments

@mbercx
Copy link
Member

mbercx commented May 11, 2021

As I'm testing the QE app by trying to break stuff and tweaking the layout/content somewhat, I'm going to run into issues I don't immediately know how to fix, but want to keep track of. I'll keep these in this issue, and either try to fix them myself, or call in the cavalry (@csadorf and @yakutovicha).

  • Warning loads when opening the QE app that reads:

    WARNING The pseudo potential families required for this app are not yet installed. In step 2: click on 'Pseudopotential', and then on 'Install pseudos' to install them.

    However, the "Pseudo potentials" tab (which I think doesn't need to hyphenated) is only available in "expert" mode, so this warning will confuse laymen users.

    I think the SSSP pseudopotential libraries (or families) should be installed by default upon deployment, and the "Install pseudopotentials" button removed. Note that we also support the Pseudo dojo libraries in aiida-pseudo now, it might be interesting to extend the options users have here.

  • Codes are not configured, which is a bit of a hassle, especially when the user wants to run the PdosWorkChain to calculate the projected density of states and has to configure 3 codes.

    I think it's best to configure the default codes upon deployment.

  • The new tabs for expert mode aren't just added to the right, but some of them are inserted. That's a little weird, especially because it changes the active tab.

    I would just add the tabs on the right of the "layman" ones.

  • Consider having just one "Advanced options" tab. One issue is that the Functional choice is somewhat hidden in the "Pseudopotentials" tab. Although it is true that the pseudopotential files determine the functional, this is only because they are generated for specific functionals, so Quantum ESPRESSO reads the functional from the pseudopotential files header. However, the functional choice is quite fundamental in DFT, so I would put it front and center in an "Advanced options" tab.

    Perhaps we should just have one "Advanced Options" tab, whose UI is disabled by default. Something along the lines of what I was now working on for the "Pseudopotentials" tab:



    I think we can remove the "Expert mode" button for now, until we can think of more tabs that only experts need access to. Alternatively, we keep the expert mode and just remove the "Override" checkbox in the "Advanced options" tab. Though that would mean my hard work on adapting the opacity would be for naught. 😭

  • Currently the "k-points distance" value widget disappears when "use default k-points" is checked:



    This is fancy, but I think it would be better if the user could see what the default k-points distance is here, without having to uncheck the box.

  • When I try to set the kpoints distance, it reverts back to the default, causing endless frustration:



    That should of course not happen. 😁

  • Currently the "Select codes" tab is part of the "layman" tabs. However, if we install and set up the QE codes for the latest version by default, I think this should move into the expert mode tabs, and the codes should be configured to the defaults straight away.

  • Remove the install pseudos button. These should be installed by default, avoiding this hassle for the user.

  • Remove the "Use default X type" checkboxes for the spin and electronic type. Just put in the defaults and let them select the type.

  • Rephrase the work chain definition in terms of properties to calculate.

  • Add an explanation to the new "Properties" section.

  • Make the "POSITIONS_CELL" the default choice for the geometry optimization. @csadorf this refuses to work 😠 . I should just add a value argument to the Dropdown, no? Moved to 🐛 FIX: Make POSITIONS_CELL the default selection #58

  • Remove the "Parameters" tab for now. I think this will be very nice when the process builder can have a nice representation in HTML, sort of like here: ✨ NEW: _repr_pretty_ representation for ProcessBuilder aiidateam/aiida-core#4970

  • Switch "Advanced Settings" and "Compute resources" tabs.

Things to double check:

Questions

  • What purpose do the "Previous Step" and "Next Step" buttons serve? Are they outdated? EDIT: Seems you can indeed move between steps with them (but only "Next Step" seems to work?). I would remove this entire line of buttons. You can just click on the steps now, right? So why would you use these? The "Reset" button seems more important, but I'd instead have a nice big button on the top left or right that says "Start new workflow!". Moved to 👌 IMPROVE: Clean up top-level UI #56

Bugs to fix

@mbercx mbercx added the enhancement New feature or request label May 11, 2021
@mbercx mbercx self-assigned this May 11, 2021
@mbercx mbercx linked a pull request Jun 5, 2021 that will close this issue
@mbercx mbercx changed the title Minor layout and UX issues 👌 IMPROVE: Minor layout and UX issues Jun 5, 2021
@mbercx
Copy link
Member Author

mbercx commented Jun 8, 2021

Closed by #54

@mbercx mbercx closed this as completed Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant