Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify Python setters to convert units #5

Open
mcgibbon opened this issue Oct 8, 2019 · 0 comments
Open

Modify Python setters to convert units #5

mcgibbon opened this issue Oct 8, 2019 · 0 comments

Comments

@mcgibbon
Copy link
Collaborator

mcgibbon commented Oct 8, 2019

In VulcanClimateModeling/fv3gfs#6 the setter functions assume the DataArrays have the correct units as expected by the Fortran code. It would be safer if it checks and converts units as necessary. There is code to do this already in the sympl package that we could take advantage of.
@mcgibbon mcgibbon transferred this issue from another repository Oct 30, 2019
mcgibbon pushed a commit that referenced this issue Jul 30, 2020
Run MPI tests on circleci, fix tests (#5)
bb3eff6 
When fv3util was split into a separate repo, the MPI tests were disabled. This PR re-enables them and fixes the test code to reflect internal API changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcgibbon