Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --allow-run-as-root flag only when in docker #11

Open
mcgibbon opened this issue Nov 3, 2019 · 2 comments
Open

Use --allow-run-as-root flag only when in docker #11

mcgibbon opened this issue Nov 3, 2019 · 2 comments

Comments

@mcgibbon
Copy link
Collaborator

mcgibbon commented Nov 3, 2019

There are several scripts (especially tests) where we pass --allow-run-as-root to mpirun. We should detect whether we are running inside a docker container (maybe specifically our docker container, from some environment variable we set inside it) and only pass this flag when we're inside a container. This would prevent users from running tests as root in their main system where doing so might cause damage to their OS.

@ofuhrer
Copy link
Contributor

ofuhrer commented Nov 3, 2019

It is standard practice to create a user inside a docker container to run MPI jobs afaik. Singularity and other HPC container runtimes do provide workarounds, though.

@mcgibbon
Copy link
Collaborator Author

mcgibbon commented Nov 3, 2019

Yeah, that might be a better fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants