Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a DevOps, I want to create unit tests for the remove previous image script #26

Closed
ThomasCardin opened this issue Jan 30, 2024 · 3 comments · Fixed by #27
Closed

As a DevOps, I want to create unit tests for the remove previous image script #26

ThomasCardin opened this issue Jan 30, 2024 · 3 comments · Fixed by #27
Assignees

Comments

@ThomasCardin
Copy link
Member

ThomasCardin commented Jan 30, 2024

Create automated test from remove previous image script

@ThomasCardin ThomasCardin self-assigned this Jan 30, 2024
@ThomasCardin ThomasCardin changed the title As a DevOps, I want to create unit test for the remove-previous-image.py script As a DevOps, I want to create unit tests for the remove-previous-image.py script Jan 30, 2024
@ThomasCardin ThomasCardin moved this to Todo in DevSecOps Jan 30, 2024
@ThomasCardin ThomasCardin changed the title As a DevOps, I want to create unit tests for the remove-previous-image.py script As a DevOps, I want to create unit and integration tests for the remove-previous-image.py script Jan 31, 2024
@rngadam
Copy link

rngadam commented Jan 31, 2024

Not sure we should be expressing user stories "As a DevOps, ..." for things that aren't really:

A user story is an informal, general explanation of a software feature written from the perspective of the end user. Its purpose is to articulate how a software feature will provide value to the customer.

Automated testing ought to be part of any software engineering endeavor (same as documentation and version control). We're making an exception here so we can move this part of the infrastructure in.

@SonOfLope
Copy link
Contributor

Not sure we should be expressing user stories "As a DevOps, ..." for things that aren't really:

A user story is an informal, general explanation of a software feature written from the perspective of the end user. Its purpose is to articulate how a software feature will provide value to the customer.

Automated testing ought to be part of any software engineering endeavor (same as documentation and version control). We're making an exception here so we can move this part of the infrastructure in.

I'd like to clarify the intent behind the phrase "As a DevOps" used in the issue description. The term 'DevOps' in our context, though traditionally a mindset and culture, is being used here to reference the specific responsibilities and needs associated with our operational roles. In essence, I think Thomas's use of "As a DevOps" was not to redefine DevOps as a role, but to pinpoint the scope of the task within our current role-based structure.

The purpose of this phrasing was to provide clarity on who would primarily benefit from the creation of these tests (in this case, team members who are handling the operations and deployment aspects of our projects - the DevOps team). The intent is to identify the primary user or beneficiary of a particular task or feature.

Moreover, I agree with you that automated testing is a fundamental aspect of modern software development and should be ingrained in our workflow. However, I believe Thomas's user story was a pragmatic approach to highlight the specific application of this practice for our operational tasks.

I hope this clarifies our perspective. Furthermore, if there's a belief that our team isn't the primary beneficiary of these tests, this opens an important discussion about the broader application of DevOps practices.

In an ideal scenario, DevOps principles should be embraced by all developers, encompassing not just development but also deployment and operational responsibilities. The notion of a segregated 'DevOps team' handling these aspects in isolation does not fully align with the DevOps mindset, which advocates for a more integrated and collaborative approach between development and operations.

@rngadam
Copy link

rngadam commented Feb 1, 2024

I'd like to clarify the intent behind the phrase "As a DevOps" used in the issue description. The term 'DevOps' in our context, though traditionally a mindset and culture, is being used here to reference the specific responsibilities and needs associated with our operational roles. In essence, I think Thomas's use of "As a DevOps" was not to redefine DevOps as a role, but to pinpoint the scope of the task within our current role-based structure.

can't disagree with anything you said. my disagreement is with the title presenting this as a user story as testing is builtin to the engineering process; so it's a postponed task. It doesn't create value in itself, it is an artifact of building good software.

ThomasCardin added a commit that referenced this issue Feb 6, 2024
ThomasCardin added a commit that referenced this issue Nov 1, 2024
ThomasCardin added a commit that referenced this issue Nov 1, 2024
ThomasCardin added a commit that referenced this issue Nov 22, 2024
@ThomasCardin ThomasCardin changed the title As a DevOps, I want to create unit and integration tests for the remove-previous-image.py script As a DevOps, I want to removed the previous image from a built docker image Nov 22, 2024
@ThomasCardin ThomasCardin changed the title As a DevOps, I want to removed the previous image from a built docker image As a DevOps, I want to create unit tests for the remove previous image script Nov 22, 2024
ThomasCardin added a commit that referenced this issue Nov 22, 2024
ThomasCardin added a commit that referenced this issue Nov 22, 2024
…nit-tests-for-the-remove-previous-imagepy-script

issue #26: Migrated script from github-worflows. Missing unit and int…
@github-project-automation github-project-automation bot moved this from Todo to Done in DevSecOps Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants