Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Final Newline in .json File Generation Process #13

Open
1 of 6 tasks
ibrahim-kabir opened this issue Apr 2, 2024 · 2 comments
Open
1 of 6 tasks

Ensure Final Newline in .json File Generation Process #13

ibrahim-kabir opened this issue Apr 2, 2024 · 2 comments
Assignees

Comments

@ibrahim-kabir
Copy link
Collaborator

ibrahim-kabir commented Apr 2, 2024

Summary

The current process responsible for generating .json files is not adding a final newline at the end of the file. This missing newline can cause issues with certain tools that rely on this newline for correct parsing. To prevent potential problems, we need to update the generation process to include a final newline in the .json files it generates.

Tasks

  • Investigate the current implementation of the .json file generation process
  • Modify the process to append a final newline character at the end of the generated .json files
  • Test the updated process to ensure the newline is correctly added and does not impact the existing functionality
  • Document the changes made to the .json file generation process

PR related

Acceptance Criteria

  • .json files generated by the process should include a final newline character at the end of the file
  • The updated process should not introduce any regressions or impact existing functionality
  • Documentation should be updated to reflect the changes made to the .json file generation process
@ibrahim-kabir
Copy link
Collaborator Author

@JolanThomassin could you add to your PR ai-cfia/ailab-db#96 a newline to the json files generated by the script ? Add this to the GitHub issue description closes ai-cfia/api-test#13

@JolanThomassin
Copy link

Yes, I will add an EoF for the next one

@ibrahim-kabir ibrahim-kabir moved this from Todo to In Progress in Finesse Apr 15, 2024
@ibrahim-kabir ibrahim-kabir moved this from In Progress to Paused in Finesse Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Blocked
Development

No branches or pull requests

2 participants