Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Prefix for SQLAlchemyDataStore #928

Open
1 task done
jgz opened this issue Jun 19, 2024 · 4 comments
Open
1 task done

Table Prefix for SQLAlchemyDataStore #928

jgz opened this issue Jun 19, 2024 · 4 comments

Comments

@jgz
Copy link

jgz commented Jun 19, 2024

Things to check first

  • I have searched the existing issues and didn't find my feature already requested there

Feature description

Ability to add a prefix to the table names when setting up a SQLAlchemyDataStore.

I tried doing what's mentioned in #722 but it doesn't work. The table name is still hardcoded in other places and I didn't want to go down that rabbit hole.

Use case

Would save me some mental damage every time I look at my tables in pgadmin.

@dgtlmoon
Copy link

dgtlmoon commented Jul 8, 2024

Very cool :)

@agronholm
Copy link
Owner

Could you elaborate what you mean by "it doesn't work"? What did you try and why didn't it work?

@agronholm
Copy link
Owner

Have you considered using a separate schema (by passing the schema parameter to SQLAlchemyDataStore?

@jgz
Copy link
Author

jgz commented Jul 29, 2024

I did consider using a different schema, but ultimately the table names not having a prefix wasn't a deal breaker for me so I just used it the way it is. It's just annoying and triggers my OCD a bit and I could see it being a problem for others.

It's been a few weeks since I set it up and posted this, so I forget exactly what the issue was with the proposed fix from the #722 . I'll try and look into it again this week and post a better explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants