v.2.19.4-rc1 & rc2 no more main menu bar displayed #42
Comments
|
Now the Purr Data menu bar under v.2.19.4-rc2 (OBS/JGU purr-data-2.19.4.r5108.2f69601d-1-x86_64) is well displayed under Manjaro Linux 24.0.6 (Arch Linux) Cinnamon (6.2.7) 64-bit. So no menu issue here. When the Ubuntu Studio 24.04.1 upgrade (from 22.04.4) will be available I will test it too. |
|
Sounds like a GTK theming issue on Mint for me. Purr Data uses Chromium as
its underlying GUI toolkit, so there might be something out of whack there.
The upgrade to nw.js 0.42.0 on Linux might also play a role. You could try
a different nw.js version, like 0.28.3 (the one we used previously) or
0.67.0 (the "last known good" version on Linux). They can be downloaded
from https://dl.nwjs.io/. Use the -sdk-*-linux-x64 package (e.g.,
https://dl.nwjs.io/v0.67.0/nwjs-sdk-v0.67.0-linux-x64.tar.gz) and replace
/opt/purr-data/lib/pd-l2ork/bin/nw with the contents of the directory in
the downloaded tarball).
Good luck!
Albert
…On Wed, Aug 14, 2024 at 3:14 AM joe-rouen ***@***.***> wrote:
Now the Purr Data menu bar under v.2.19.4-rc2 (OBS/JGU
purr-data-2.19.4.r5108.2f69601d-1-x86_64) is well displayed under Manjaro
Linux 24.0.6 (Arch Linux) Cinnamon (6.2.7) 64-bit. So no menu issue here.
When the Ubuntu Studio 24.04.1 upgrade (from 22.04.4) will be available I
will test it too.
—
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVYYWI254TXNQOJOZZFLELZRKVQPAVCNFSM6AAAAABMOT5VI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBXGYYDIMZTGQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Dr. Albert Gr"af
Computer Music Research Group, JGU Mainz, Germany
Email: ***@***.***, web: https://agraef.github.io/
|
|
Well, effectively GTK theming could be an issue with LM 22. More to read e.g. here. nw.js: Comparing Purr Data and Pd-L2Ork we have the following version: 0.42.0 vs 0.67.1. LTS to LTS for Ubuntu 24.04.1 upgrade has been postponed to end of August by its development team. So I will test it later on when available.
|
|
No luck with nwjs-sdk-v0.67.0-linux-x64.tar.gz! So as SuperUser I reviewed/changed in the /opt/purr-data/lib/pd-l2ork/bin/nw folder (0.67.0) the permissions of most folders / files taking the original nw folder as reference. Still no luck. Putting back the original nw folder (0.42.0) Purr Data is working except of course the main menu bar display. Any idea how to fix nw.js 0.67.0 issue? |
|
Yeah, there are probably missing permissions in the downloaded tarball.
IIRC, you need to set the files world-readable (and the directories and
programs world-executable) to make them work. Otherwise, only root will be
able to read and execute them. (That's taken care of automatically in the
build scripts I'm using.)
About the menu bar not displaying: Do you have a screenshot of how it looks
like? Do the menu shortcuts work? (E.g., try opening a patch with Ctrl+O.)
If that works, then it's most likely just a theming issue. Otherwise it's
something more serious.
…On Wed, Aug 14, 2024 at 6:19 PM joe-rouen ***@***.***> wrote:
No luck with nwjs-sdk-v0.67.0-linux-x64.tar.gz!
After moving the content of the downloaded tarball to
/opt/purr-data/lib/pd-l2ork/bin/nw Purr Data is not launching.
Trying to run it from a terminal I'm getting:
***@***.***:~$ purr-data
guidir is /opt/purr-data/lib/pd-l2ork/bin
priority 6 scheduling enabled.
sh: 1: /opt/purr-data/lib/pd-l2ork/bin/nw/nw: Permission denied
So as SuperUser I reviewed/changed in the
/opt/purr-data/lib/pd-l2ork/bin/nw folder (0.67.0) the permissions of most
folders / files taking the original nw folder as reference. Still no luck.
Putting back the original nw folder (0.42.0) Purr Data is working except
of course the main menu bar display.
Any idea how to fix nw.js 0.67.0 issue?
—
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVYYWOLLD64V6KY6KLMZRDZRN7SHAVCNFSM6AAAAABMOT5VI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBZGIZTEMZZGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Dr. Albert Gr"af
Computer Music Research Group, JGU Mainz, Germany
Email: ***@***.***, web: https://agraef.github.io/
|
|
Oops, sorry, I just realized that this was actually on the issue tracker, and the emails didn't show me the screenies. :) Yes, it's dark mode, plain and simple, which seems to mess with the themeing. Looks similar in KDE in dark mode for me (using nw.js 0.42.3):
I'll look into it immediately. Maybe I need to upgrade to a newer nw.js version. Thanks for reporting! |
|
Yeah, updating to 0.67.0 resolves it:
I'll commit a fix on testing shortly. |
This fixes a bug with the menubar being white on white (and hence invisible) when using a dark theme. 0.67.0 resolves the issue, and while it has some minor regressions, it's perfectly usable, and is as close as we can get to the 0.67.1 version we're using on Mac and Windows (which has a nasty regression with nwwworkingdir not working on Linux, which breaks Purr Data's file dialogs).
|
hyy everyone i am new here and wish to contribute to this project can someone guide me |
This fixes a bug with the menubar being white on white (and hence invisible) when using a dark theme. 0.67.0 resolves the issue, and while it has some minor regressions, it's perfectly usable, and is as close as we can get to the 0.67.1 version we're using on Mac and Windows. (Unfortunately, 0.67.1 itself has a nasty regression on Linux which breaks Purr Data's file dialogs. But 0.67.0 will do for now.)
|
@harshisageek You could begin by not hijacking other people's bug reports. ;-) If you've used Purr Data and are familiar with the code base, then just send a PR and I will look at it. |
|
@joe-rouen Sorry, I was busy with fixing other, unrelated bugs. Now that the testing branch has settled, I'll do another build, so that you can test my fix on Mint. I'll give you a heads-up once the OBS build is done. |
|
@joe-rouen The latest test builds are now available at home:aggraef:test. This should hopefully fix the issue. Can you please grab the package and give it another go on Mint? |
|
@agraef Thank you very much for your help and support. :-) |
This fixes a bug with the menubar being white on white (and hence invisible) when using a dark theme. 0.67.0 resolves the issue, and while it has some minor regressions, it's perfectly usable, and is as close as we can get to the 0.67.1 version we're using on Mac and Windows. (Unfortunately, 0.67.1 itself has a nasty regression on Linux which breaks Purr Data's file dialogs. But 0.67.0 will do for now.)
This fixes a bug with the menubar being white on white (and hence invisible) when using a dark theme. 0.67.0 resolves the issue, and while it has some minor regressions, it's perfectly usable, and is as close as we can get to the 0.67.1 version we're using on Mac and Windows. (Unfortunately, 0.67.1 itself has a nasty regression on Linux which breaks Purr Data's file dialogs. But 0.67.0 will do for now.)
|
Good news indeed! :) So I can close this now. RC3 is in the making which has a bunch of other bugfixes, especially to the new listbox implementation. As you might have seen, there's a lot of goodies in the upcoming release, so I hope that you and your students will enjoy RC3. |
This fixes a bug with the menubar being white on white (and hence invisible) when using a dark theme. 0.67.0 resolves the issue, and while it has some minor regressions, it's perfectly usable, and is as close as we can get to the 0.67.1 version we're using on Mac and Windows. (Unfortunately, 0.67.1 itself has a nasty regression on Linux which breaks Purr Data's file dialogs. But 0.67.0 will do for now.)
This is the last version which doesn't have the nwworkingdir bug on Linux which causes file dialogs to open in the wrong locations. It also seems to work just as well (or at least not any worse) than 0.67.0 on Mac and Windows. The only downside is that 0.55.0 still has the dark mode bug on Linux (#42); Mac and Windows seem to be fine. But this is a cosmetic issue which can be worked around by adjusting the desktop theme, while the nwworkingdir bug breaks important functionality and has no known work-around. So I think that fixing the latter at the cost of breaking dark mode is the most sensible choice. Note that if you absolutely need to have dark mode working, you can now just use the new patch-nwjs.sh script to patch your Purr Data installation to use 0.67.0 again (the former default).
|
Unfortunately I have to reopen this because nw.js 0.67.0 has a serious regression on Linux in that it breaks nwworkingdir, which absolutely needs to work to make Purr Data's file dialogs open in the right directories. Thus I just downgraded the nw.js version to 0.55.0 which is the last version that doesn't have the nwworkingdir bug. Unfortunately, that version still has the dark mode bug instead. :( Sorry @joe-rouen, I'm not happy with this either. But given the choice between fixing a cosmetic issue which you can work around by adjusting your desktop theme, and fixing a bug that breaks important functionality (for which no work-around is known), I'll always choose the latter. I hope that you understand my reasoning here, even if you don't agree. But all is not lost. :) In the meantime I have added the patch-nwjs.sh script which lets you quickly patch up the nw.js version in your existing Purr Data installation without a recompile. This takes care of all the messy details, downloads the package, adjusts the permissions so that nw.js will actually work when used with Purr Data, and swaps out the existing nw folder in the installation. It is really easy to use if you're not afraid of the command line. Detailed instructions can be found on the Installation page in the wiki. So, after rev. c367e16 gets packaged, at least you now have the option to patch your installation back to 0.67.0 in order to make the menu look nice in dark mode -- at the expense of having broken file dialogs, that is. ;-) |
Turns out that nw.js 0.42.0 crashes a lot on newer macOS versions, so we need to upgrade to a later version. As Ico figured out a while ago, the performance issues in later versions are due to the NW2 upgrade in 0.42.4 (https://nwjs.io/blog/nw2-mode/). This can be disabled which gets JS execution performance back up to where it was in older versions. 0.55.0 is the last version which doesn't have the nwworkingdir bug on Linux which causes file dialogs to open in the wrong locations. It also seems to work just as well (or at least not any worse) than 0.67.x on Mac and Windows. The only downside is that 0.55.0 still has the dark mode bug on Linux (#42); Mac and Windows seem to be fine. But this is a cosmetic issue which can be worked around by adjusting the desktop theme, while the nwworkingdir bug breaks important functionality and has no known work-around. So I think that fixing the latter at the cost of breaking dark mode is the most sensible choice. Note that if you absolutely need to have dark mode working on Linux, you can now just use the new patch-nwjs.sh script to patch your Purr Data installation to use a later version such as 0.67.0 which doesn't have the dark mode bug.
|
I'm back after more than one week deep inside my bed! Still have to fully recover... @agraef Well, same comments than earlier this is thread: So can't nw.js version 0.67.1 solve both main menu display (theming) and nwworkingdir under the Linuxes? Note: each time when launching purr-data 2.19.4+git5146 I'm getting a short bursts of an auto-gun with small dark windows (the whole takes less than few tenths of seconds) then Purr Data is opening. It's weird. |
No. The Linux nwworkingdir bug is present on all nw.js versions after 0.55.0. That's precisely why I downgraded to that version.
I suspect that this is the small dialog window that briefly appears after a downgrade of the nw.js version. Remove the nw.js config in ~/.config/purr-data (not ~/.purr-data, that's where your actual Purr Data config is stored!), then that should be fixed. That is: rm -rf ~/.config/purr-dataI'm not sure whether that will make the other messages in the terminal go away, but these should be harmless as long as purr-data runs for you. |
|
Ok, I labeled this as bug - wontfix for now, but I'm keeping it open, because we might be able to fix this eventually, if a future nw.js version fixes the nwworkingdir bug on Linux, and fixes either the close-event bug in NW1 mode (if that then still exists) or the serious JS execution performance regression in NW2 mode. That's a tall order, though, so I'm not holding my breath for that to happen. 😞 |
|
But, to reiterate what I wrote above, there is a work-around. If you're not bothered by file dialogs showing the wrong locations, and you absolutely can't live without dark mode, then you can just run the new patch-nwjs.sh script to upgrade the nw.js version in your existing Purr Data installation. Download the script to a directory where you have write permission and make sure that the script is executable. The following command will then update to nw.js 0.67.1 so that the menu shows properly in dark mode. (0.67.1 is the latest version that will work in NW1 mode. Don't use any later version.) ./patch-nwjs.sh 0.67.1Detailed instructions on patch-nwjs.sh can be found on the Installation page in the wiki. Obviously this work-around has its tradeoffs and thus isn't perfect, but it's what we have right now. If anyone finds a better fix that doesn't involve upgrading from nw.js 0.55.0 but still makes the menu look right in dark mode, please by all means let us know! It will be much appreciated by everyone, including @joe-rouen and me. 😉 |
In both versions (from OBS/JGU) the main menu bar content is not displayed despite the space is well present (it's true for all windows with menu bar). We have to click blindly in the menu bar space for opening a menu entry.
It was not the case with the previous several v.2.19.3.
Tested under the new Linux Mint 22 (Ubuntu 24.04 LTS) Cinnamon 6.2.9 (64-bit). For the time being I can't test it under other OSes.
The text was updated successfully, but these errors were encountered: