Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonnet: pass top level args providing build context #137

Closed
sgotti opened this issue Oct 10, 2019 · 4 comments
Closed

jsonnet: pass top level args providing build context #137

sgotti opened this issue Oct 10, 2019 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sgotti
Copy link
Member

sgotti commented Oct 10, 2019

We should pass some toplevel arguments to the jsonnet parser to ease the generation of the final config file without relying on build information currently only provided at runtime via environment variables:

  • run ref type (branch, tag, pull request)
  • git branch
  • git tag
  • git ref
  • git commitsha
@m8nmueller
Copy link

You can assign me but it could take a few days until I find some time to do this.

@sgotti
Copy link
Member Author

sgotti commented Oct 21, 2019

@MaxM123 Sorry but I already opened a PR with an initial implementation in #141 (would you like to review it?). If you want you can use it as a starting point for the implementation of the Starlark config language in #138 .

@m8nmueller
Copy link

Okay, great :). I can have a look at that but I will probably need some time to get to know Starlak and reorganize your configuration module (a little bit) to be able to check for which format to use. But I would be glad to work on that if you let me do that ;).
I will have a look at your PR but I guess, review isn't too necessary for that code if you wrote it.

@sgotti
Copy link
Member Author

sgotti commented Mar 10, 2020

Implemented in #141

@sgotti sgotti closed this as completed Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants