Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services Vertical Extent guidance references datasets #123

Open
archaeogeek opened this issue Oct 10, 2023 · 4 comments
Open

Services Vertical Extent guidance references datasets #123

archaeogeek opened this issue Oct 10, 2023 · 4 comments
Labels
Guidance Issues that primarily affect the general or element guidance, not the "normative" parts

Comments

@archaeogeek
Copy link
Member

  • I think we need to review in detail the Purpose and Meaning, and the Guidance, so it is clear exactly how this element should be applied to metadata for services. Currently, I believe its unclear e.g. is the element to record the vertical domains of each data resource the service operates on, or is it something else?
  • Encoding guidance note 1 is extremely verbose and ambiguous in my opinion. Think it also needs to be re-assessed and re-worded for clarity.
  • Encoding guidance note 2 quotes "must be provided in order to give meaning to the minimum and maximum coordinates". There is not a useful subsequent sentence detailing what "in order" means.
  • Encoding examples 1 and 2 use MD_DataIdentification when they should be using SV_ServiceIdentification
@archaeogeek archaeogeek added the Guidance Issues that primarily affect the general or element guidance, not the "normative" parts label Oct 10, 2023
@nmtoken
Copy link
Contributor

nmtoken commented Oct 10, 2023

Agree that examples should use <srv:SV_ServiceIdentification> instead of <gmd:MD_DataIdentification id="XYZ-...">

@nmtoken
Copy link
Contributor

nmtoken commented Oct 10, 2023

Currently, I believe its unclear e.g. is the element to record the vertical domains of each data resource the service operates on, or is it something else

Agree that some clarification may be in order. My reading is it is the vertical extents of the data as exposed by the service, which may not be the same as vertical extents of the data operated on; the same clarification should accompany other extents descriptions (temporal, extent, bounding box), that is a service may apply some restrictions to the extents it offers for any dataset it operates on.

@nmtoken
Copy link
Contributor

nmtoken commented Oct 10, 2023

Encoding guidance note 2 quotes "must be provided in order to give meaning to the minimum and maximum coordinates". There is not a useful subsequent sentence detailing what "in order" means.

The original guidance note (http://ogcdev.bgs.ac.uk/AGI/gem23-sv.html#44) was:

The CRS of vertical extent elements must be provided in order to give meaning to the minimum and maximum coordinates. From the CRS, for example, it is possible to determine the orientation of the coordinate system axis (i.e. do positive values increase upwards or downwards from the zero reference) and the units of the coordinate values.

@archaeogeek
Copy link
Member Author

75090e3 fixes the incorrect encoding in the examples but the rest needs further discussion

@archaeogeek archaeogeek moved this from To do to In progress in GEMINI issue handling Sep 6, 2024
@archaeogeek archaeogeek removed their assignment Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Guidance Issues that primarily affect the general or element guidance, not the "normative" parts
Projects
Status: In progress
Development

No branches or pull requests

2 participants