Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show proposal comments in review screen #120

Open
ceci opened this issue Mar 12, 2014 · 7 comments
Open

Show proposal comments in review screen #120

ceci opened this issue Mar 12, 2014 · 7 comments

Comments

@ceci
Copy link
Contributor

ceci commented Mar 12, 2014

As a... reviewer
I want... to be able to ask an author for clarifications regarding his submission, during the submission period
So that... the review process is more interactive and fair.

@hugocorbucci
Copy link
Member

How does that work? Is it something that only reviewers have access to? Is it a form in the review page? Is it just comments again?

@ceci
Copy link
Contributor Author

ceci commented Jun 14, 2015

This is also kinda working well with the reviewers comments. Maybe, just maybe, this could turn into "showing session comments on the review process".

What do you think, @raphaelmolesim, @ericabriones and @gmotta?

@gmotta
Copy link
Contributor

gmotta commented Jun 15, 2015

I'm a bit confused. The issue says "during submission period".

On the review pages (after submission period), as reviwers, do we see the comments? I believe not, but we can always read them or open on another tab.

On the submission page (during and after) I believe it is working just fine. Reviewers add comments and authors are replying.

@hugocorbucci
Copy link
Member

How are we feeling about this now?

@ceci
Copy link
Contributor Author

ceci commented Apr 9, 2016

I feel like we've been successfully using the comments for that purpose ("allowing clarification"), and this issue should turn into making this information easily accessible at the time of the reviews.

As a... reviewer
I want... to see the comments a session had during the submission period
So that... I can take into consideration the author's engagement on enhancing the submissions, and also the suggestions and clarification requests received.

@ericabriones
Copy link

I agree with the new user story @ceci proposed. I actually didn't even realized that they weren't visible during the review period, but I guess that's because I work with so many tabs open that I end up seeing them anyway. Nonetheless the rule should remain that only modifications applied to the submission will be considered.

@hugocorbucci hugocorbucci added this to the Agile Brazil 2016 closing milestone May 4, 2016
@hugocorbucci hugocorbucci changed the title Allow clarification from authors Show proposal comments in review screen Mar 19, 2018
@gmotta gmotta added Low and removed High labels Mar 25, 2018
@gmotta
Copy link
Contributor

gmotta commented Mar 25, 2018

I was looking into how comments were implemented in the 1st place back in 2010.
176d367#diff-2a0701eaa5d32b4adbeb9d9198cb07a0

I think this is a good enhancement, but again, we have been living without it. Reviewers just lookup comments (or ignore them). As for the people on this thread, it seems that everyone opens the review in a tab and the actual proposal on another to read the comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants