Skip to content
This repository has been archived by the owner on Mar 30, 2023. It is now read-only.

callbacks called with same context #51

Closed
clrnd opened this issue Jan 29, 2015 · 3 comments
Closed

callbacks called with same context #51

clrnd opened this issue Jan 29, 2015 · 3 comments
Labels

Comments

@clrnd
Copy link

clrnd commented Jan 29, 2015

This is not the same as #50

It seems every callback is called with the same context, meaning for example a this binding will reference an old object in a second callback.

This could be caused by having keepCallback(true) before every callbackContext.sendPluginResult
in Sms.java: https://github.com/aharris88/phonegap-sms-plugin/blob/master/src/android/Sms.java#L62

@clrnd
Copy link
Author

clrnd commented Jan 29, 2015

Effectively, commenting said line fixes it. But I have no knowledge of Android programming and can't fully understand the consequences of the modification.

@agarrharr agarrharr added the bug label Feb 5, 2015
@agarrharr
Copy link
Owner

Please see issue #53

@dbaq
Copy link

dbaq commented Feb 5, 2015

let's follow up there: cordova-sms/cordova-sms-plugin#10

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants