Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate "original-" jar to project build directory instead of output directory #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smartin1018
Copy link

@smartin1018 smartin1018 commented Jul 1, 2021

A configuration

<finalName>Foo</finalName>
<outputDirectory>bar/</outputDirectory>

Will produce a jar named Foo.jar and original-Foo.jar in the bar/ directory. This PR moves the original-Foo.jar to the appropriate build directory (e.g. target/).

I'm not very familiar with maven conventions, so if there is a better solution that involve project parameters I'd be happy to use that. I personally don't like the idea of filling a specified output directory with previous versions of jars, so this aims to remedy that.

@md-5
Copy link
Collaborator

md-5 commented Jul 1, 2021

What does maven shade do? We should have the same behaviour as that

@smartin1018
Copy link
Author

smartin1018 commented Jul 1, 2021

https://stackoverflow.com/questions/4088701/maven-shaded-jar-is-prefixed-with-original-in-the-file-name/8696195
It’s the same behavior. But it seems as though there’s no built in way to change it either. Like I said, there is a possibility of adding a parameter?

@md-5
Copy link
Collaborator

md-5 commented Jul 3, 2021

I think matching maven shade behaviour is correct, it's what is expected by the vast majority of users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants