Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] translate plain text in opendocument templates #79

Open
wants to merge 1 commit into
base: 8.0
Choose a base branch
from

Conversation

StefanRijnhart
Copy link

@sraps
Copy link
Contributor

sraps commented Jan 28, 2016

I am not too happy of including this functionality in Aeroo, mainly because of following points:

  1. It would definitely degrade report's generation performance. I think of multi-page documents, like contracts with several tens or hundreds (or even more) of paragraphs.
  2. At the moment it is not clear what happens with heavily inline formatted text paragraphs (bold, italic, superscript, references, etc). IMHO they would break into bunch of pieces. Anyway this needs testing.
  3. It would be better if there would be some sort of configuration option to turn this feature on, otherwise, this is huge change in terms of whole idea what and how it is being translated.
  4. It is unclear then what is being translated and at what point in time, when including bunch of text with directive.
  5. At the moment there is an option to use "<_()>" directive with placeholder fields, so t is easy to include text and format translation in place. So this is costly improvement, for the functionality that can be easily done in other way.

Please comment on this.

@StefanRijnhart
Copy link
Author

Thanks for your response.

1 & 3: shall we resolve this by making this a configurable option per report (default to False)?
2: this is transparent: 'inline' formatted nodes are their own TEXT node, whose contents appear in a separate translation entry. Does this answer 4 as well?
5. The benefit of using Aeroo with its Libreoffice templates is that the templates can easily be modified by the actual users of the system. Wrapping all text in their own placeholders completely subverts this advantage.

@StefanRijnhart StefanRijnhart force-pushed the 8.0-translate_plain_text_oo_hbrunn branch from 51a8707 to e446216 Compare January 28, 2016 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants