[ENH] add type hinting to _shapelet_transform __init__ #1917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Part of #1910 and references #1454
What does this implement/fix? Explain your changes.
Added type hints to
__init__
method inside of _shapelet_transform.pyDoes your contribution introduce a new dependency? If yes, which one?
New dependency added: "typing" library
Any other comments?
A) Optional[int]
B) Union[None, int]
I think option A is the generally preferred, but I saw option B in other aeon code.
E.g. aeon/similarity_search/query_search.py
Np.inf is a float. Is it ok to modify that parameter to be "int or float"?
E.g. contract_max_n_shapelet_samples: Union[int, float] = np.inf
PR checklist
For all contributions