-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Type hints for primitives and string arguments:Part1 #1472
Conversation
Thank you for contributing to
|
All the checks are passed successfully. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current ones here do not match the docstring currently as well I'm pretty sure.
n_jobs could be Optional[int]
(defaults to None)
distance and weights could be Union[str, Callable]
(accepts functions)
Reference Issues/PRs
Fixes #1454
What does this implement/fix? Explain your changes.
Adding type hints to 2 methods in the script: aeon.classification.distance_based._time_series_neighbors.
Methods are : init(), get_test_params()
Does your contribution introduce a new dependency? If yes, which one?
None
Any other comments?
Type hints are NOT added in other methods since they were not primitive types.