Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Counters parameters doesn't show up anymore #646

Closed
Juknum opened this issue May 11, 2023 · 0 comments · Fixed by #647
Closed

[BUG] Counters parameters doesn't show up anymore #646

Juknum opened this issue May 11, 2023 · 0 comments · Fixed by #647
Assignees
@imperosol
Labels
b: core

Comments

@Juknum
Copy link
Member

Juknum commented May 11, 2023

Related to #643

Since update of the User.is_in_group() method and the implementation of the cache, space characters are replaced by underscores _ to remove memcache warnings, but its not working properly. (as shown below)

According to zsoldosp/django-admin-caching#8 (comment) this "will only hide the problem", so a better solution need to be implemented.

I'll make a PR that remove the space character replacement as a temporary solution, I will let it open for some days

With → _ Without
@Juknum Juknum added severity: high The issue reports incorrect functionality, bad functionality, a confusing user experience, etc b: core labels May 11, 2023
@Juknum Juknum added this to Sith v3 May 11, 2023
@github-project-automation github-project-automation bot moved this to Todo in Sith v3 May 11, 2023
@Juknum Juknum moved this from Todo to En Cours in Sith v3 May 11, 2023
@Juknum Juknum mentioned this issue May 11, 2023
Merged
@Juknum Juknum linked a pull request May 11, 2023 that will close this issue
[FIX] Fix cached groups #647
Merged
@Juknum Juknum removed the severity: high The issue reports incorrect functionality, bad functionality, a confusing user experience, etc label May 11, 2023
@Juknum Juknum closed this as completed Sep 6, 2023
@github-project-automation github-project-automation bot moved this from En Cours to Déployé en production in Sith v3 Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imperosol imperosol

Labels
b: core
Projects
Sith v3
Status: Déployé en production
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] Fix cached groups ae-utbm/sith
2 participants
@Juknum @imperosol