Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with php5.5+ #104

Open
Mouradif opened this issue Oct 27, 2017 · 2 comments
Open

Not compatible with php5.5+ #104

Mouradif opened this issue Oct 27, 2017 · 2 comments
Assignees

Comments

@Mouradif
Copy link

Hi there

This project uses a custom class called Generator. Under php5.5+ this class name is reserved and can't be redeclared. Fortunately, there's only two lines in one file (GameEngine/Generator.php lines 12 and 159) to edit to fix this by renaming the class and using the new name in its instantiation.

As for php 7, all mysql_ prefixed functions must be removed. That's a much harder task to perform but if pull requests are welcome, I might get to it since I will be running this script on my server under php 7 if possible (I'm currently testing it under PHP 5.6 after renaming the Generator class)

@BannukDE
Copy link

Fix for 7 would be nice.
Even as Fork!

@advocaite
Copy link
Owner

I have not looked at this script since forever make a pull request and ill try get that done thanks.

@advocaite advocaite self-assigned this Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants