Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The IaC results use absolute paths #138

Open
lukaspj opened this issue May 1, 2024 · 4 comments
Open

[Bug]: The IaC results use absolute paths #138

lukaspj opened this issue May 1, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@lukaspj
Copy link

lukaspj commented May 1, 2024

What happened?

The results from this IaC extension has absolute paths somewhere, which means that GitHub can't link issues to the file.
The results from clicking the "view file" button here:
image
Goes to:
https://github.com/{org}/{repo}/blob/main//home/runner/work/{repo}/{path}.Dockerfile#L51

Version

0.1.0

Relevant log output

No response

@lukaspj lukaspj added the bug Something isn't working label May 1, 2024
@GeekMasher
Copy link
Contributor

Thanks for raising this @lukaspj, sad I am away the rest of the week and next. Does this urgently need fixing?

@lukaspj
Copy link
Author

lukaspj commented May 2, 2024

Nope, it only applies to what it considers as syntax errors, so it doesn’t affect all our repositories and the syntax error should be fixable if we can figure out what it doesn’t like

@GeekMasher
Copy link
Contributor

When you say "syntax errors", is that in the Dockerfile or something else? Maybe there is an issue with the parser / analysis

@lukaspj
Copy link
Author

lukaspj commented May 2, 2024

Well I only know what’s in the screenshot 😅

but it’s only an issue in a single repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants