Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android AudioAttributes can't be adjusted for SimpleAudioPlayer #84

Open
gkarabin opened this issue Jul 27, 2021 · 0 comments
Open

Android AudioAttributes can't be adjusted for SimpleAudioPlayer #84

gkarabin opened this issue Jul 27, 2021 · 0 comments

Comments

@gkarabin
Copy link

I would like to for my app to be able to change the Android AudioAttributes associated with the MediaPlayer instance in SimpleAudioPlayerImplementation.cs.

I can think of two obvious approaches: either expose the underlying MediaPlayer (which has Dispose logic to account for) or add methods to allow runtime setting of the AudioAttributes. I would like to get your opinion on which approach you'd prefer, if any, for a PR.

It occurs to me that it would make sense to make similar changes for the other implementations, at which point some simplicity is lost in favor of flexibility. I could see not wanting this change at all for that reason.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant