restoring the --openjdk-source-location after PR#2702 #4066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judovana
changed the title
|
All linux builds failed. Seems unrelated. Seems related to removal of node16 |
|
@sxa @ anybody... may I ask for review if possible? |
I'm having a long overdue PR review catch up and have just made it to the temurin-build repo so I'm on it now ;-)
Covered in #4064 so if you rebase that should fix itself. |
sxa
approved these changes
Dec 4, 2024
judovana
force-pushed
the
sourcesDirWorkAgain
branch
from
dc988ae to
ae8a6b8
Compare
|
Thanx! I had rebased to see the actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4065
I may have limited availability today. If it is ok, feel free to merge as necessary.