Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK11: Aarch64: Mac: Build cannot find boot JDK locally or via web api #4058

Closed
adamfarley opened this issue Nov 25, 2024 · 4 comments
Closed
Assignees
Labels
aarch Issues that affect or relate to the aarch ARCHITECTURE arm Issues that affect or relate to the ARM OS buildbreak High priority issues that cause build breaks in jenkins or build scripts macos Issues that affect or relate to the MAC OS openj9 Issues that are enhancements or bugs raised against the OpenJ9 group testing Issues that enhance or fix our test suites

Comments

@adamfarley
Copy link
Contributor

Thank you for reporting a broken build! Please fill in the following details:

21:01:57  Downloading ga release of boot JDK version 10 from https://api.adoptium.net/v3/binary/latest/10/ga/mac/aarch64/jdk/hotspot/normal/eclipse
21:01:58  Downloading ga release of boot JDK version 10 from https://api.adoptium.net/v3/binary/latest/10/ga/mac/aarch64/jdk/hotspot/normal/adoptium
21:01:58  Downloading ga release of boot JDK version 10 from https://api.adoptium.net/v3/binary/latest/10/ga/mac/aarch64/jdk/hotspot/normal/adoptopenjdk
21:01:59  Downloading ga release of boot JDK version 10 from https://api.adoptopenjdk.net/v3/binary/latest/10/ga/mac/aarch64/jdk/hotspot/normal/eclipse
21:01:59  Downloading ga release of boot JDK version 10 from https://api.adoptopenjdk.net/v3/binary/latest/10/ga/mac/aarch64/jdk/hotspot/normal/adoptium
21:01:59  Downloading ga release of boot JDK version 10 from https://api.adoptopenjdk.net/v3/binary/latest/10/ga/mac/aarch64/jdk/hotspot/normal/adoptopenjdk
21:01:59  Downloading ea release of boot JDK version 10 from https://api.adoptium.net/v3/binary/latest/10/ea/mac/aarch64/jdk/hotspot/normal/eclipse
21:02:00  Downloading ea release of boot JDK version 10 from https://api.adoptium.net/v3/binary/latest/10/ea/mac/aarch64/jdk/hotspot/normal/adoptium
21:02:01  Downloading ea release of boot JDK version 10 from https://api.adoptium.net/v3/binary/latest/10/ea/mac/aarch64/jdk/hotspot/normal/adoptopenjdk
21:02:01  Downloading ea release of boot JDK version 10 from https://api.adoptopenjdk.net/v3/binary/latest/10/ea/mac/aarch64/jdk/hotspot/normal/eclipse
21:02:01  Downloading ea release of boot JDK version 10 from https://api.adoptopenjdk.net/v3/binary/latest/10/ea/mac/aarch64/jdk/hotspot/normal/adoptium
21:02:02  Downloading ea release of boot JDK version 10 from https://api.adoptopenjdk.net/v3/binary/latest/10/ea/mac/aarch64/jdk/hotspot/normal/adoptopenjdk
21:02:02  BOOT JDK: /Users/admin/workspace/workspace/build-scripts/jobs/jdk11u/jdk11u-mac-aarch64-temurin/build-farm/platform-specific-configurations/mac.sh: line 146: /Users/admin/workspace/workspace/build-scripts/jobs/jdk11u/jdk11u-mac-aarch64-temurin/jdk10/Contents/Home/bin/java: No such file or directory

Passing builds appear to already have a version of jdk10 on the machine itself.
However, as of 3 weeks ago, we are now looking for the jdk in a different location: 01ba85f
My theory is that the JDK is still located in the folder that has the dash.

Possible fix for the "missing jdk" problem: We either need to modify the code to check both dash'd and undash'd locations, or we could modify the orka template to have its jdk10 in the new location.

Possible fix the for "can't find jdk10 at Adoptium" issue: If the boot jdk is jdk10, we need to change the url it's trying to download from, because the Adoptium api says it has no JDK10 builds. Evidence.

@adamfarley adamfarley added the buildbreak High priority issues that cause build breaks in jenkins or build scripts label Nov 25, 2024
@github-actions github-actions bot added aarch Issues that affect or relate to the aarch ARCHITECTURE arm Issues that affect or relate to the ARM OS macos Issues that affect or relate to the MAC OS openj9 Issues that are enhancements or bugs raised against the OpenJ9 group testing Issues that enhance or fix our test suites labels Nov 25, 2024
@sxa
Copy link
Member

sxa commented Nov 25, 2024

Passing builds appear to already have a version of jdk10 on the machine itself.
However, as of 3 weeks ago, we are now looking for the jdk in a different location: 01ba85f

Yep that will almost certainly be the cause and the orka image will need to be regenerated to put it in the correct place. Since these are dynamic I can't just override the variable on the machine in jenkins.

Possible fix the for "can't find jdk10 at Adoptium" issue: If the boot jdk is jdk10, we need to change the url it's trying to download from, because the Adoptium api says it has no JDK10 builds. Evidence.

The API is correct, we do not have a native build of JDK10 on macos/aarch64. The playbooks pull in an x64 one which will run under the Rosetta emulation layer on the aarch64 hosts

@adamfarley
Copy link
Contributor Author

Orka image rebuild has been requested here.

If this cannot be resolved before the Xmas break, I suggest we add some temporary code to accommodate both the old and new locations (01ba85f) on Mac.

@adamfarley
Copy link
Contributor Author

adamfarley commented Dec 2, 2024

Step 1) Short term fix: #4071

Step 2) Long term fix discussion: https://adoptium.slack.com/archives/C53GHCXL4/p1733159401774789

Step 3) Once the long-term fix is in, the short-term fix should be undone.

This issue (#4058) should not be closed until all three tasks are completed.

Do not undo the short term fix until the long term fix is confirmed complete.

@adamfarley
Copy link
Contributor Author

Ok, the Orka node update looks like it'll be a while in the doing, so I'm shifting Step 3 into that issue and closing this one. We don't need more than one issue open for this.

@github-project-automation github-project-automation bot moved this from In Progress to Done in 2024 4Q Adoptium Plan Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch Issues that affect or relate to the aarch ARCHITECTURE arm Issues that affect or relate to the ARM OS buildbreak High priority issues that cause build breaks in jenkins or build scripts macos Issues that affect or relate to the MAC OS openj9 Issues that are enhancements or bugs raised against the OpenJ9 group testing Issues that enhance or fix our test suites
Projects
Status: Done
Development

No branches or pull requests

2 participants