Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release branch approval is currently only 1 review, should it be 2 ? #4047

Closed
andrew-m-leonard opened this issue Nov 19, 2024 · 2 comments
Closed

release branch approval is currently only 1 review, should it be 2 ? #4047

andrew-m-leonard opened this issue Nov 19, 2024 · 2 comments
Assignees
@andrew-m-leonard
Labels
question Issues that are queries about the code base or potential problems that have been spotted testing Issues that enhance or fix our test suites

Comments

@andrew-m-leonard
Copy link
Contributor

build repo and aqa-test "release" branch PRs have only 1 approver, should it be 2 ?
@andrew-m-leonard andrew-m-leonard self-assigned this Nov 19, 2024
@github-actions github-actions bot added question Issues that are queries about the code base or potential problems that have been spotted testing Issues that enhance or fix our test suites labels Nov 19, 2024
@andrew-m-leonard andrew-m-leonard moved this to In Progress in 2024 4Q Adoptium Plan Nov 19, 2024
@andrew-m-leonard andrew-m-leonard added the PMC-agenda For the PMC to review label Nov 19, 2024
@smlambert
Copy link
Contributor

smlambert commented Nov 19, 2024 •
edited
Loading

we decided for aqa-tests branches that we only needed 1 reviewer, as the PRs being merged into branches should be almost exclusively items cherry-picked from master (that have been previously reviewed by 2 committers)

@andrew-m-leonard
Copy link
Contributor Author

andrew-m-leonard commented Dec 4, 2024 •
edited
Loading

Completed, decision to use 2 reviews for build repo release branches, now implemented.

@github-project-automation github-project-automation bot moved this from In Progress to Done in 2024 4Q Adoptium Plan Dec 4, 2024
@andrew-m-leonard andrew-m-leonard removed the PMC-agenda For the PMC to review label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrew-m-leonard andrew-m-leonard

Labels
question Issues that are queries about the code base or potential problems that have been spotted testing Issues that enhance or fix our test suites
Projects
2024 4Q Adoptium Plan
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smlambert @andrew-m-leonard