-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status of Reproducible comparing tests on linux #3967
Comments
I see , most of September openjdk pipeline jobs disabled tests job as it's in Release period, which causes only one job with jdk24 available. adoptium/temurin#54 (comment) |
@sophia-guo jdk-21.0.5+9 EA is building now.... so you should have a new test to look at soon... The above differences need looking at, for Linux they should be 100% identical, I suspect an "environmental" difference that we need to investigate in this issue. I suspect one of:
@sophia-guo What would be really useful output in the test, is if the "classlist" file appears in the diff, then do a verbose content diff just for that file, as that will reveal any of the differences suggested above ^ |
I think you mentioned @andrew-m-leonard
|
The latest results -
linux-aarch64 and ppc64le have the same result
|
If the "classlist" file appears in the diff, do a verbose content diff just for that file by 'diff -r,' results:
https://ci.adoptium.net/job/Grinder/11263/ Using https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk21u/job/jdk21u-linux-x64-temurin/286/artifact/workspace/target/OpenJDK21U-jdk_x64_linux_hotspot_2024-10-15-21-58.tar.gz tag: 21.0.4+7 |
@andrew-m-leonard #3967 (comment) updated the verbose output. |
thanks @sophia-guo so yes the problem is one env has ipv6 enabled the other doesn't... we need to fix one of the environments |
We maybe able to dynamically disable it using a sysctl maybe ? |
temurin build environment is adoptopenjdk/centos7_build_image and reproducible is uisng centos:7. It seems adoptopenjdk/centos7_build_image IPV6 is enabled while centos:7 isn't? @andrew-m-leonard are you talking about disable it in temurin build? |
Google notes Red-hat based distributions, Change to the root user. sysctl -w net.ipv6.conf.all.disable_ipv6=1 To re-enable IPv6, type these commands: |
@sophia-guo i'm thinking the test script could dynamically enable in the container possibly using sysctl, would need testing to see if it works? |
Did a try. Seems this can be done by configure namespaced kernel parameters (sysctls) at runtime (--sysctl). Note Docker does not support changing sysctls inside of a container that also modify the host system. https://docs.docker.com/reference/cli/docker/container/run/#sysctl |
@sophia-guo Looks good?
|
@andrew-m-leonard yes, the PR is here #4020 |
PPC64le and aarch64 was enabled on Sep 25th. adoptium/ci-jenkins-pipelines#1115. There is no data yet as no betaTrigger builds triggered with test enabled.
Recent linux update was merged in Sep 6th. .
Most recent ea pipeline jobs are triggered by test disabled (not sure why, for example https://ci.adoptium.net/job/build-scripts/job/openjdk21-pipeline/333/), which means most reproducible comparing tests are quite old and may not be worth looking at. FYI @smlambert @andrew-m-leonard
Only one test build with jdk24 is with recent update. https://trss.adoptium.net/output/test?id=66f72b85d24e1b006ee0dd01 @andrew-m-leonard triggered by https://ci.adoptium.net/job/build-scripts/job/openjdk24-pipeline/25/, test jenkins job is https://ci.adoptium.net/job/Test_openjdk24_hs_special.system_x86-64_linux/11/. Both job and rerun job have same results. 6 files differs.
@andrew-m-leonard I remember you mentioned those CDS files differences ( 4 files) are a known issue due to the classlist ipv6 difference. Compared with the job I tested before https://ci.adoptium.net/job/Test_openjdk23_hs_special.system_x86-64_linux_testList_0/29/console, number of files increased and two more file differs. jmods/expanded_java.base.jmod/lib/server/libjvm.so and /lib/server/libjvm.so and tarJDK/jdk-24+17/lib/server/libjvm.so. Are those two differences expected?
The text was updated successfully, but these errors were encountered: