Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jdk17u Win32 build failure: Cannot open include file: 'sys/statfs.h' #3527

Closed
andrew-m-leonard opened this issue Nov 9, 2023 · 6 comments
Closed

jdk17u Win32 build failure: Cannot open include file: 'sys/statfs.h' #3527

andrew-m-leonard opened this issue Nov 9, 2023 · 6 comments
Assignees
@sxa
Labels
buildbreak High priority issues that cause build breaks in jenkins or build scripts Reported to OpenJDK / JBS Issues that have been reported upstream to the OpenJDK community testing Issues that enhance or fix our test suites windows Issues that affect or relate to the WINDOWS OS

Comments

@andrew-m-leonard
Copy link
Contributor

jdk17u Win32 builds broken: https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk17u/job/jdk17u-windows-x86-32-temurin/289/console

02:10:33  * For target support_test_jdk_jtreg_native_support_libGetXSpace_libGetXSpace.obj:
02:10:33  libGetXSpace.c
02:10:33  c:\workspace\openjdk-build\workspace\build\src\test\jdk\java\io\File\libGetXSpace.c(37): fatal error C1083: Cannot open include file: 'sys/statfs.h': No such file or directory
@andrew-m-leonard andrew-m-leonard added the buildbreak High priority issues that cause build breaks in jenkins or build scripts label Nov 9, 2023
@github-actions github-actions bot added testing Issues that enhance or fix our test suites windows Issues that affect or relate to the WINDOWS OS labels Nov 9, 2023
@sxa
Copy link
Member

sxa commented Nov 9, 2023

Oh that's the one I had to fix for JDK21 - needs _WIN32 in the #ifdef replaced with a generic windows one. I was considering upstreaming that but I guess if it's been backported it's even more critical now

@sxa
Copy link
Member

sxa commented Nov 11, 2023

In discussion with Andrew about getting this fixed upstream since I have a patch that works.

@sxa sxa self-assigned this Nov 11, 2023
@sxa
Copy link
Member

sxa commented Nov 13, 2023 •
edited
Loading

Upstream PR to jdk22 codebase: https://github.com/openjdk/jdk/pull/16628/checks?check_run_id=18622446178
Linked upstream bug report: https://bugs.openjdk.org/browse/JDK-8319958
Testing against the same patch applied to the jdk17u codebase:

@sxa
Copy link
Member

sxa commented Nov 17, 2023

Awaiting sponsor for backport to JDK17: openjdk/jdk17u-dev#1958

@karianna karianna added the Reported to OpenJDK / JBS Issues that have been reported upstream to the OpenJDK community label Nov 17, 2023
@sxa
Copy link
Member

sxa commented Nov 22, 2023

Fix now in jdk17u-dev

@sxa
Copy link
Member

sxa commented Dec 13, 2023

Upstream patche merged therefore closing.

@sxa sxa closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sxa sxa

Labels
buildbreak High priority issues that cause build breaks in jenkins or build scripts Reported to OpenJDK / JBS Issues that have been reported upstream to the OpenJDK community testing Issues that enhance or fix our test suites windows Issues that affect or relate to the WINDOWS OS
Projects
No open projects
Adoptium 4Q 2023 Plan
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karianna @sxa @andrew-m-leonard