-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign JMOD Windows exe/dll's using exploded/assemble method #822
Conversation
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
run tests |
PR TESTER RESULT ❎ Some pipelines failed or the job was aborted! ❎ |
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
run tests |
PR TESTER RESULT ✅ All pipelines passed! ✅ |
) * Enable JMOD signing for Windows Signed-off-by: Andrew Leonard <[email protected]> * Enable JMOD signing for Windows Signed-off-by: Andrew Leonard <[email protected]> * Enable JMOD signing for Windows Signed-off-by: Andrew Leonard <[email protected]> * Enable JMOD signing for Windows Signed-off-by: Andrew Leonard <[email protected]> * Enable JMOD signing for Windows Signed-off-by: Andrew Leonard <[email protected]> * Enable JMOD signing for Windows Signed-off-by: Andrew Leonard <[email protected]> * Enable JMOD signing for Windows Signed-off-by: Andrew Leonard <[email protected]> * Enable JMOD signing for Windows Signed-off-by: Andrew Leonard <[email protected]> * Enable JMOD signing for Windows Signed-off-by: Andrew Leonard <[email protected]> * Enable JMOD signing for Windows Signed-off-by: Andrew Leonard <[email protected]> * Enable JMOD signing for Windows Signed-off-by: Andrew Leonard <[email protected]> * Enable JMOD signing for Windows Signed-off-by: Andrew Leonard <[email protected]> * Enable JMOD signing for Windows Signed-off-by: Andrew Leonard <[email protected]> * Enable JMOD signing for Windows Signed-off-by: Andrew Leonard <[email protected]> --------- Signed-off-by: Andrew Leonard <[email protected]>
Add Windows to the exploded/assemble JDK build JMOD Signing method, currently only used for Mac.
Fixes: #814
Test build: https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-windows-x64-temurin/302/
sanity.openjdk test: https://ci.adoptium.net/view/Test_openjdk/job/Test_openjdk11_hs_sanity.openjdk_x86-64_windows/823/
sanity.system test: https://ci.adoptium.net/view/Test_system/job/Test_openjdk11_hs_sanity.system_x86-64_windows/810/