Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign JMOD Windows exe/dll's using exploded/assemble method #822

Merged
merged 14 commits into from
Sep 30, 2023

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Sep 29, 2023

@andrew-m-leonard andrew-m-leonard self-assigned this Sep 29, 2023
@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@andrew-m-leonard
Copy link
Contributor Author

run tests

@andrew-m-leonard andrew-m-leonard changed the title Sign Windows exe/dll's using exploded/assemble method Sign JMOD Windows exe/dll's using exploded/assemble method Sep 29, 2023
@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

@github-actions github-actions bot added testing windows x64 Issues that affect or relate to the x64/x32 LINUX OS labels Sep 29, 2023
@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@andrew-m-leonard
Copy link
Contributor Author

run tests

@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

✅ All pipelines passed! ✅

@karianna karianna merged commit 9ff239d into adoptium:master Sep 30, 2023
7 checks passed
luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
)

* Enable JMOD signing for Windows

Signed-off-by: Andrew Leonard <[email protected]>

* Enable JMOD signing for Windows

Signed-off-by: Andrew Leonard <[email protected]>

* Enable JMOD signing for Windows

Signed-off-by: Andrew Leonard <[email protected]>

* Enable JMOD signing for Windows

Signed-off-by: Andrew Leonard <[email protected]>

* Enable JMOD signing for Windows

Signed-off-by: Andrew Leonard <[email protected]>

* Enable JMOD signing for Windows

Signed-off-by: Andrew Leonard <[email protected]>

* Enable JMOD signing for Windows

Signed-off-by: Andrew Leonard <[email protected]>

* Enable JMOD signing for Windows

Signed-off-by: Andrew Leonard <[email protected]>

* Enable JMOD signing for Windows

Signed-off-by: Andrew Leonard <[email protected]>

* Enable JMOD signing for Windows

Signed-off-by: Andrew Leonard <[email protected]>

* Enable JMOD signing for Windows

Signed-off-by: Andrew Leonard <[email protected]>

* Enable JMOD signing for Windows

Signed-off-by: Andrew Leonard <[email protected]>

* Enable JMOD signing for Windows

Signed-off-by: Andrew Leonard <[email protected]>

* Enable JMOD signing for Windows

Signed-off-by: Andrew Leonard <[email protected]>

---------

Signed-off-by: Andrew Leonard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenkins-pipeline testing windows x64 Issues that affect or relate to the x64/x32 LINUX OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign Windows JMOD exe/dlls, so jlink images contain signed artifacts
4 participants