Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jdk_restricted_security test #5782

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

LongyuZhang
Copy link
Contributor

@LongyuZhang LongyuZhang commented Dec 2, 2024

Add jdk_restricted_security test

Issue: Runtimes_Automation 119

@LongyuZhang LongyuZhang marked this pull request as draft December 2, 2024 19:21
@LongyuZhang
Copy link
Contributor Author

Test link:

  • hyc_grinder 45206

openjdk/playlist.xml Outdated Show resolved Hide resolved
openjdk/playlist.xml Outdated Show resolved Hide resolved
@taoliult
Copy link

taoliult commented Dec 2, 2024

Another question: Does the directory structure in this PR ibmruntimes/openj9-openjdk-jdk#871 look good?

@LongyuZhang LongyuZhang force-pushed the ffipp8 branch 2 times, most recently from d3e890a to 684442c Compare December 3, 2024 18:59
@LongyuZhang
Copy link
Contributor Author

LongyuZhang commented Dec 3, 2024

Test links (hyc_grinder):

  • (pass) xlinux: 45446
  • (pass) zlinux: 45458
  • (pass) plinux: 45459
  • aix JDK11: 45455
    • TestProperties passed, but TestProviders failed
  • xmac JDK11: 45554
    • both test failed
  • xmac JDK8: 45456
    • Error: Cannot find file: /Users/jenkins/workspace/Grinder/aqa-tests/TKG/../openjdk/openjdk-jdk/closed/test/jdk/openj9/internal/security , may need to modify the path for it.
  • amac JDK11: 45457
    • TestProperties passed, but TestProviders failed
  • win: JDK11: 45460
    • TestProperties passed, but TestProviders failed

@taoliult
Copy link

taoliult commented Dec 4, 2024

@LongyuZhang For those failed ones, do you have the job link for it?

@llxia
Copy link
Contributor

llxia commented Dec 4, 2024

For those failed ones, do you have the job link for it?

@taoliult please use Grinder job in hyc + job number in #5782 (comment)

@taoliult
Copy link

taoliult commented Dec 4, 2024

@LongyuZhang @llxia

For aix JDK11: 45455, amac JDK11: 45457 and win: JDK11: 45460, working on the fix, because for provider SunJSSE, its fully qualified name in JDK11 is com.sun.net.ssl.internal.ssl.Provider.

For xmac JDK8: 45456m. The error is “[2024-12-03T22:23:00.452Z] Error: Cannot find file: /Users/jenkins/workspace/Grinder/aqa-tests/TKG/../openjdk/openjdk-jdk/closed/test/jdk/openj9/internal/security”.

The test cases in JDK8 are in the directory “https://github.com/ibmruntimes/openj9-openjdk-jdk8/tree/openj9/closed/adds/jdk/test/jdk/openj9/internal/security” The “/closed/adds/jdk/test/jdk/openj9/internal/security” directory, same directory as the closed src folder, not the “/closed/test/jdk/openj9/internal/security”.

Do I need to change the test case codes directory in JDK8 to “/closed/test/jdk/openj9/internal/security”?

@taoliult
Copy link

taoliult commented Dec 5, 2024

@LongyuZhang @llxia

I am using my personal build and personal repo for testing TestProviders failed fix. But the test is disabled due to "only applicable for Semeru atm". Can't this test be used for nightly build or personal build?

18:55:07  ===============================================
18:55:07  Running test jdk_restricted_security_j9_0 ...
18:55:07  ===============================================
18:55:07  jdk_restricted_security_j9_0 Start Time: Wed Dec  4 18:55:07 2024 Epoch Time (ms): 1733356507576
18:55:07  jdk_restricted_security_j9_0_DISABLED
18:55:07  Disabled Reason:
18:55:07  only applicable for Semeru atm
18:55:07  jdk_restricted_security_j9_0 Finish Time: Wed Dec  4 18:55:07 2024 Epoch Time (ms): 1733356507614

@llxia
Copy link
Contributor

llxia commented Dec 5, 2024

But the test is disabled due to "only applicable for Semeru atm". Can't this test be used for nightly build or personal build?

As per your request #5782 (comment), the test is set to be Semeru-specific. If you wish to run it against OpenJ9, it would no longer be Semeru-specific. Could you please clarify your requirements?

@taoliult
Copy link

taoliult commented Dec 5, 2024

But the test is disabled due to "only applicable for Semeru atm". Can't this test be used for nightly build or personal build?

As per your request #5782 (comment), the test is set to be Semeru-specific. If you wish to run it against OpenJ9, it would no longer be Semeru-specific. Could you please clarify your requirements?

@llxia Sorry I misunderstood that question about "Semeru specific". We would like this tests can be run, for example, same as the jdk_security tests, which can be run on Semeru, Nightly and Personal build.

And also, for JDK8 test failures, the test cases in JDK8 are in the directory “https://github.com/ibmruntimes/openj9-openjdk-jdk8/tree/openj9/closed/adds/jdk/test/jdk/openj9/internal/security” The “/closed/adds/jdk/test/jdk/openj9/internal/security” directory, same directory as the closed src folder, not the “/closed/test/jdk/openj9/internal/security”.

Do I need to change the test case codes directory in JDK8 to “/closed/test/jdk/openj9/internal/security”?

openjdk/playlist.xml Outdated Show resolved Hide resolved
@llxia
Copy link
Contributor

llxia commented Dec 5, 2024

re for JDK8 test failures, is there a particular reason to have adds/jdk folders?

@taoliult
Copy link

taoliult commented Dec 5, 2024

re for JDK8 test failures, is there a particular reason to have adds/jdk folders?

No, no particular reason, I put those codes there, just for under the same directory with the src folder.

├── adds
│   └── jdk
│       ├── src
│       └── test

@llxia
Copy link
Contributor

llxia commented Dec 5, 2024

Ok, it may be better for @LongyuZhang to do the change as he is testing the PR, just in case there is any other structure-related change. @LongyuZhang could you please remove adds/jdk in the openjdk8 extension repo? Thanks

@LongyuZhang LongyuZhang changed the title Add jdk_restricted_security_j9 test Add jdk_restricted_security test Dec 6, 2024
@LongyuZhang LongyuZhang force-pushed the ffipp8 branch 2 times, most recently from 9264ee2 to 852b202 Compare December 6, 2024 17:59
Add jdk_restricted_security test

Signed-off-by: LongyuZhang <[email protected]>
@LongyuZhang LongyuZhang marked this pull request as ready for review December 6, 2024 18:34
@LongyuZhang
Copy link
Contributor Author

Discussed with Lan, will enable this test for JDK11+ currently, with disable aix, mac, and win (track in runtimes/automation/issues/151).

Test Links (hyc_grinder):
xlinux: 45446
zlinux: 45458
plinux: 45459
aix: (disabled so skip) 45574

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We will enable JDK8 in a separate PR.

@JasonFengJ9 JasonFengJ9 merged commit 75bc280 into adoptium:master Dec 6, 2024
2 of 3 checks passed
@llxia
Copy link
Contributor

llxia commented Dec 6, 2024

@taoliult @jasonkatonica do we need to run these restricted security tests for the 0.49 release (Jan release)?

@jasonkatonica
Copy link
Contributor

Hi @llxia we would like to run these tests as soon since we have no coverage for the restricted security mode profile code. This being said we are ok missing the .49 deadlines if the timing does not work for this feature or if we run into issues.

@taoliult
Copy link

taoliult commented Dec 6, 2024

@taoliult @jasonkatonica do we need to run these restricted security tests for the 0.49 release (Jan release)?

If we can catch up the 0.49 deadline, yes, we can enable these tests for the 0.49 release.

And for the JDK11 TestProviders tests failures, I will open an OpenJDK PR for that. The root cause for those failures are the provider SunJSSE fully qualified name are different between JDK11 and JDK17. I will update the SunJSSE for those test cases on JDK11 TestProviders tests.

LongyuZhang added a commit to LongyuZhang/aqa-tests that referenced this pull request Dec 6, 2024
Add jdk_restricted_security test

Signed-off-by: LongyuZhang <[email protected]>
llxia pushed a commit that referenced this pull request Dec 6, 2024
Add jdk_restricted_security test

Signed-off-by: LongyuZhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants