-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jdk_restricted_security test #5782
Conversation
Test link:
|
Another question: Does the directory structure in this PR ibmruntimes/openj9-openjdk-jdk#871 look good? |
d3e890a
to
684442c
Compare
Test links (hyc_grinder):
|
@LongyuZhang For those failed ones, do you have the job link for it? |
@taoliult please use Grinder job in hyc + job number in #5782 (comment) |
For For The test cases in JDK8 are in the directory “ Do I need to change the test case codes directory in JDK8 to “ |
I am using my personal build and personal repo for testing
|
As per your request #5782 (comment), the test is set to be Semeru-specific. If you wish to run it against OpenJ9, it would no longer be Semeru-specific. Could you please clarify your requirements? |
@llxia Sorry I misunderstood that question about " And also, for JDK8 test failures, the test cases in JDK8 are in the directory “https://github.com/ibmruntimes/openj9-openjdk-jdk8/tree/openj9/closed/adds/jdk/test/jdk/openj9/internal/security” The “/closed/adds/jdk/test/jdk/openj9/internal/security” directory, same directory as the closed src folder, not the “/closed/test/jdk/openj9/internal/security”. Do I need to change the test case codes directory in JDK8 to “/closed/test/jdk/openj9/internal/security”? |
re for JDK8 test failures, is there a particular reason to have |
No, no particular reason, I put those codes there, just for under the same directory with the
|
Ok, it may be better for @LongyuZhang to do the change as he is testing the PR, just in case there is any other structure-related change. @LongyuZhang could you please remove |
9264ee2
to
852b202
Compare
Add jdk_restricted_security test Signed-off-by: LongyuZhang <[email protected]>
Discussed with Lan, will enable this test for JDK11+ currently, with disable aix, mac, and win (track in runtimes/automation/issues/151). Test Links (hyc_grinder): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We will enable JDK8 in a separate PR.
@taoliult @jasonkatonica do we need to run these restricted security tests for the 0.49 release (Jan release)? |
Hi @llxia we would like to run these tests as soon since we have no coverage for the restricted security mode profile code. This being said we are ok missing the .49 deadlines if the timing does not work for this feature or if we run into issues. |
If we can catch up the 0.49 deadline, yes, we can enable these tests for the 0.49 release. And for the JDK11 |
Add jdk_restricted_security test Signed-off-by: LongyuZhang <[email protected]>
Add jdk_restricted_security test Signed-off-by: LongyuZhang <[email protected]>
Add jdk_restricted_security test
Issue: Runtimes_Automation 119