Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating JCK references for jck17 to jck17a #5780

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Updating JCK references for jck17 to jck17a #5780

merged 1 commit into from
Dec 19, 2024
+27 −13

Conversation

adamfarley
Copy link
Contributor

Resolves #5748

@adamfarley adamfarley mentioned this pull request Nov 28, 2024
Closed
@adamfarley
Copy link
Contributor Author

adamfarley commented Nov 28, 2024 •
edited
Loading

May not be testable until the tck repo has changes as well. - Update: It turns out that this is not the case.

Working on that here: https://github.com/temurin-compliance/temurin-compliance/issues/601

Update: tck repo changes complete. PR here: https://github.com/temurin-compliance/temurin-compliance/pull/602

Testing: https://ci.eclipse.org/temurin-compliance/job/Grinder/4646/

@karianna
Copy link
Contributor

Grinder failed...

@smlambert
Copy link
Contributor

New Grinder launched at:
https://ci.eclipse.org/temurin-compliance/job/Grinder/4647
with different TARGET value that exists.

@adamfarley
Copy link
Contributor Author

adamfarley commented Nov 29, 2024 •
edited by smlambert
Loading

The new Grinder (with a valid target, good catch Shelley) has also failed.

Update: Ticket raised.

@adamfarley adamfarley changed the title Updating JCK references for jck17 to jck17a WIP: Updating JCK references for jck17 to jck17a Nov 29, 2024
@adamfarley
Copy link
Contributor Author

Changing title to WIP, as this change it not safe to merge until it has been tested, and it cannot be tested until this confidential Eclipse issue is resolved.

@smlambert smlambert marked this pull request as draft November 29, 2024 19:32
@adamfarley adamfarley changed the title WIP: Updating JCK references for jck17 to jck17a Updating JCK references for jck17 to jck17a Dec 19, 2024
@adamfarley adamfarley marked this pull request as ready for review December 19, 2024 11:22
@adamfarley
Copy link
Contributor Author

adamfarley commented Dec 19, 2024 •
edited
Loading

Tested as detailed in the TCK issue. Some unit test failures, but 99% of everything passed, and nothing seemed to have trouble finding the jck17a test material.

@karianna karianna merged commit 7bb358e into adoptium:master Dec 19, 2024
2 checks passed
@adamfarley
Copy link
Contributor Author

Thanks @karianna and @ShelleyLambert 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

@karianna karianna karianna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jck17a version
3 participants
@adamfarley @karianna @smlambert