Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase -Xmx option for Jfr #5767

Merged
merged 3 commits into from
Dec 8, 2024
Merged

Increase -Xmx option for Jfr #5767

merged 3 commits into from
Dec 8, 2024

Conversation

sophia-guo
Copy link
Contributor

Close #3492

Note: when using jdk_custom for jdk_jfr testcases the default -Xmx is still 512.
Also enable jdk_custom with different mode.

@sophia-guo
Copy link
Contributor Author

Grinder testing branch is also set jdk_custom with -Xmx768m for test only, change is not in this PR branch.

https://ci.adoptium.net/view/Test_grinder/job/Grinder/11642/
https://ci.adoptium.net/view/Test_grinder/job/Grinder/11643/

@llxia
Copy link
Contributor

llxia commented Nov 20, 2024

Also enable jdk_custom with different mode.

Variation in jdk_custom was removed on purpose. See #4495 (comment) and #4572

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this PR contains commits from other PRs. Please remove unnecessary commits.

karianna
karianna previously approved these changes Nov 22, 2024
@karianna karianna dismissed their stale review November 22, 2024 08:23

Missed the uneeded commits

@sophia-guo sophia-guo self-assigned this Nov 23, 2024
@sophia-guo sophia-guo marked this pull request as draft November 23, 2024 15:57
@sophia-guo sophia-guo marked this pull request as ready for review December 5, 2024 16:57
@sophia-guo sophia-guo requested review from llxia and karianna December 6, 2024 15:48
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophia-guo sophia-guo requested review from karianna and removed request for karianna December 6, 2024 17:49
@karianna
Copy link
Contributor

karianna commented Dec 8, 2024

linter failure unrelated

@karianna karianna merged commit eba7631 into adoptium:master Dec 8, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jdk/jfr/jcmd/TestJcmdDump.java.TestJcmdDump consistently failing in jdk18+36 Release Triage
3 participants