Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exclude_parser.py to error when ProblemList format has issues #5650

Closed
jiekang opened this issue Sep 26, 2024 · 4 comments · Fixed by #5651
Closed

Update exclude_parser.py to error when ProblemList format has issues #5650

jiekang opened this issue Sep 26, 2024 · 4 comments · Fixed by #5651
Assignees

Comments

@jiekang
Copy link
Contributor

jiekang commented Sep 26, 2024

The exclude_parser.py runs as a GH action when changes are made to the ProblemList. It should error when issues with their syntax are found.

See also:
#5633
#5227

@sophia-guo
Copy link
Contributor

Current the disableTestsLinter (pull_request) can detect the error but won't fail the check
Disabled Tests Linter / disableTestsLinter (pull_request) Successful in 14sdisable test won't fail the check https://github.com/adoptium/aqa-tests/actions/runs/11801561188/job/32875177726

@sophia-guo
Copy link
Contributor

For extra space between os-arch, a simple check would be removing the maxsplit=2

split_line = test_excl.raw_line.split(maxsplit=2)

@sophia-guo
Copy link
Contributor

We need to fail the github check process for all errors.

@smlambert
Copy link
Contributor

We want to make sure there are exactly 3 sections per line in a ProblemList file (each separated by a space)
Testclass | URL_to_open_issue | os-arch_comma-separatedList

and then verify that each has content that "looks right", which I thought the script already does (though perhaps not with the set of options we currently run it with)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants