Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adoptium.net 2215 translate the asciidoc contributors #2216

Merged
merged 8 commits into from
Sep 13, 2023
Merged

Adoptium.net 2215 translate the asciidoc contributors #2216

merged 8 commits into from
Sep 13, 2023

Conversation

xavierfacq
Copy link
Member

@xavierfacq xavierfacq commented Sep 13, 2023 •
edited
Loading

Description of change

This PR is to fix the issue #2215

Add new translations in locales/fr/asciidoc.json to report in other languages

Translated parts are (impacting asciidoc):
image

And this part:
image

Checklist

  • npm test passes
  • documentation is changed or added (if applicable)

@netlify
Copy link

netlify bot commented Sep 13, 2023 •
edited
Loading

✅ Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 83044b4
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/6501a9c7c7d0110008c8795a
😎 Deploy Preview https://deploy-preview-2216--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gdams gdams linked an issue Sep 13, 2023 that may be closed by this pull request
Translation request, we should translate the Asciidoc contributors/Edit this page section of the website #2215
Closed
@gdams

This comment was marked as resolved.

Sign in to view
gdams
gdams reviewed Sep 13, 2023
View reviewed changes
locales/fr/asciidoc.json
@@ -1,4 +1,9 @@
{
"asciidoc.template.warn.default.locale": "Cette page est la <englishVersionLink>version en anglais</englishVersionLink> car elle n'existe pas dans votre langue. Aidez-nous à la traduire en français. Consultez notre <translationGuideLink>guide de traduction</translationGuideLink> pour plus d'informations.",
"asciidoc.template.warn.outdated": "Cette page est la <englishVersionLink>version en anglais</englishVersionLink> car elle n'existe pas dans votre langue. Aidez-nous à traduire la dernière <englishVersionLink>version en anglais</englishVersionLink>. Consultez notre <translationGuideLink>guide de traduction</translationGuideLink> pour plus d'informations."
"asciidoc.template.warn.outdated": "Cette page est la <englishVersionLink>version en anglais</englishVersionLink> car elle n'existe pas dans votre langue. Aidez-nous à traduire la dernière <englishVersionLink>version en anglais</englishVersionLink>. Consultez notre <translationGuideLink>guide de traduction</translationGuideLink> pour plus d'informations.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hendrikebbers @zdtsw can you fill in the German/Chinese gaps for this PR?

@codecov
Copy link

codecov bot commented Sep 13, 2023 •
edited
Loading

Codecov Report

Merging #2216 (83044b4) into main (5788210) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2216   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files          87       87           
  Lines        6504     6515   +11     
  Branches      554      553    -1     
=======================================
+ Hits         6452     6463   +11     
  Misses         52       52
Files Changed Coverage Δ
src/components/AuthorList/index.tsx 100.00% <100.00%> (ø)
src/components/EditLink/index.tsx 100.00% <100.00%> (ø)
src/components/RandomContributor/index.tsx 100.00% <100.00%> (ø)
src/templates/asciidocTemplate.tsx 100.00% <100.00%> (ø)
src/util/asciidocFormatter.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xavierfacq
Copy link
Member Author

I have added the translation of the "Thank you to a contributor" component. But I did not take in charge if there is 1 or more contributions and just suggest to use "contribution(s)" in the text.

Is it OK for you ?

@gdams
Copy link
Member

gdams commented Sep 13, 2023

I have added the translation of the "Thank you to a contributor" component. But I did not take in charge if there is 1 or more contributions and just suggest to use "contribution(s)" in the text.

Is it OK for you ?

Yeah I think that's fine

@xavierfacq
Copy link
Member Author

I have added the translation of the "Thank you to a contributor" component. But I did not take in charge if there is 1 or more contributions and just suggest to use "contribution(s)" in the text.
Is it OK for you ?

Yeah I think that's fine

Sorry, actually it is commited without '(s)'. The text is "contributions"
Do I change it for "contribution(s)" ?

@gdams
Copy link
Member

gdams commented Sep 13, 2023

I have added the translation of the "Thank you to a contributor" component. But I did not take in charge if there is 1 or more contributions and just suggest to use "contribution(s)" in the text.
Is it OK for you ?

Yeah I think that's fine

Sorry, actually it is commited without '(s)'. The text is "contributions" Do I change it for "contribution(s)" ?

yeah I think it's worth making the change

@xavierfacq xavierfacq marked this pull request as ready for review September 13, 2023 12:26
@xavierfacq xavierfacq merged commit 81917a1 into adoptium:main Sep 13, 2023
@zdtsw zdtsw mentioned this pull request Sep 13, 2023
Merged
4 tasks
@xavierfacq xavierfacq deleted the adoptium.net-2215_translate_the_asciidoc_contributors branch September 24, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdams gdams gdams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translation request, we should translate the Asciidoc contributors/Edit this page section of the website
2 participants
@xavierfacq @gdams