Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates of blog: reproducible comparison builds #2279

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

sophia-guo
Copy link
Contributor

Description of change

Checklist

  • npm test passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 9602a55
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/651ade4f180c300008fac482
😎 Deploy Preview https://deploy-preview-2279--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sophia-guo sophia-guo marked this pull request as draft October 2, 2023 13:59
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #2279 (9602a55) into main (7f318b7) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2279   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files          87       87           
  Lines        6507     6507           
  Branches      552      552           
=======================================
  Hits         6455     6455           
  Misses         52       52           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't make a github suggestion on this line but there's also a typo in the title:
Comparsion should be Comparison

@sophia-guo sophia-guo force-pushed the blog branch 2 times, most recently from 3e0d74e to e8f7074 Compare October 2, 2023 15:10
Signed-off-by: Sophia Guo <[email protected]>
@sophia-guo sophia-guo marked this pull request as ready for review October 2, 2023 19:56
@gdams gdams merged commit 325eaeb into adoptium:main Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants