Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checking if JVM_OPTIONS is empty #641

Merged
merged 1 commit into from
Nov 26, 2024
Merged

checking if JVM_OPTIONS is empty #641

merged 1 commit into from
Nov 26, 2024

Conversation

sophia-guo
Copy link
Contributor

Close #640

@sophia-guo
Copy link
Contributor Author

JVM_OPTIONS set: https://ci.adoptium.net/job/Grinder/11853 (multiple variations are NOT ran)
without JVM_OPTIONS set: https://ci.adoptium.net/job/Grinder/11855/console (multiple variations are ran)
JVM_OPTIONS set as empty: https://ci.adoptium.net/job/Grinder/11858/ ( jenkins docker pull image, multiple variations are ran)

LongyuZhang
LongyuZhang approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit 262e459 into adoptium:master Nov 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LongyuZhang LongyuZhang LongyuZhang approved these changes

@karianna karianna karianna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JVM_OPTIONS="" as an environment variable will be considered as set and variations be ignored.
3 participants
@sophia-guo @karianna @LongyuZhang