Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added bash version check #574

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Added bash version check #574

merged 1 commit into from
Jun 21, 2024

Conversation

sophiaxu0424
Copy link

Issue related to: #547

Signed-off-by: sophiaxu0424 [email protected]

Added bash version check
badc7ef 
Issue related to: adoptium#547

Signed-off-by: Minghong Xu <[email protected]>
@sophiaxu0424
Copy link
Author

Grinder Test:
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41494/

19:41:45  bashVersion : 
19:41:45  	GNU bash, version 5.0.17(1)-release (x86_64-pc-linux-gnu)
19:41:45  	Copyright (C) 2019 Free Software Foundation, Inc.
19:41:45  	License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
19:41:45

@sophiaxu0424 sophiaxu0424 marked this pull request as ready for review June 21, 2024 00:03
@sophiaxu0424
Copy link
Author

Hi @LongyuZhang would you please kindly review, thanks!

LongyuZhang
LongyuZhang reviewed Jun 21, 2024
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify your change on all platforms (xlinux, plinux, zlinux, alinux, aix, mac, win, and zos), and post the output here so we can have reference of the bash version on them. Thanks.

@sophiaxu0424
Copy link
Author

LongyuZhang
LongyuZhang approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang requested a review from smlambert June 21, 2024 18:40
smlambert
smlambert approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smlambert smlambert merged commit 9acd936 into adoptium:master Jun 21, 2024
3 checks passed
@LongyuZhang LongyuZhang mentioned this pull request Jun 21, 2024
Closed
@sophiaxu0424 sophiaxu0424 deleted the bash branch June 21, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LongyuZhang LongyuZhang LongyuZhang approved these changes

@smlambert smlambert smlambert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sophiaxu0424 @smlambert @LongyuZhang